fix: authentication issues caused by update/delete operations#127
Merged
Conversation
bietkul
changed the title
| } | ||
|
|
||
| // CredentialCache represents the cached users/credentials where key is `username` | ||
| // Auth (TODO - clear cache after fixed entries: LRU?) |
siddharthlatest
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This PR fixes the following bugs:
PATCHuser endpoint to store the hashed passwordUsers
https://www.loom.com/share/ab780d239c8545758372a8d2d4563471
Permissions
https://www.loom.com/share/34b03e09cb3d433392c77c1d186d6844
What should your reviewer look out for in this PR?
Which issue(s) does this PR fix?
If this PR affects any API reference documentation, please share the updated endpoint references