feat: improve logging with logrus#60
Merged
siddharthlatest merged 11 commits intodevfrom Dec 20, 2019
Merged
Conversation
siddharthlatest
added a commit
that referenced
this pull request
Dec 20, 2019
This reverts commit ecf84ba.
siddharthlatest
added a commit
that referenced
this pull request
Dec 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Better logging with
logrus, control the log mode by run time flag namedlog. The default mode isinfowhich can be changed todebug&error.What should your reviewer look out for in this PR?
Do you need help or clarification on anything?
Which issue(s) does this PR fix?