Skip to content

Fix/searchbox autosuggest bug #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2022
Merged

Fix/searchbox autosuggest bug #1838

merged 3 commits into from
Jan 10, 2022

Conversation

@mohdashraf010897
Copy link
Member

@mohdashraf010897 mohdashraf010897 commented Jan 10, 2022

PR Type BugFix

Description fixes a bug with autosuggest prop in the SearchBox component.

Detailed Description@ https://www.loom.com/share/51b5ebc8514b4fc3ad131ada06d08fdf

When autosuggest is false,

  • suggestions appear in the dropdown (shouldn't appear)
  • esc key doesn't close suggestions (it should close suggestions and defocus)
  • on keystroke changes, the results change (expected) but suggestions from before remain until the text is completely cleared

🧇 Also updates the failing snapshots for SearchBox.
https://www.loom.com/share/0001a77ca8eb4a0ead4a6be5ec468b60

@github-actions github-actions bot added the web label Jan 10, 2022
@bietkul bietkul marked this pull request as ready for review January 10, 2022 14:12
@bietkul bietkul merged commit 9e55b0c into next Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bietkul bietkul bietkul approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohdashraf010897 @bietkul