fix: maps examples#1928
Merged
bietkul merged 43 commits intofeat/upgrade-maps-libfrom Apr 20, 2022
Merged
Conversation
…ap and ReactiveOpenStreet
Contributor
|
@mohdashraf010897 Share a demo for all the examples you've updated. Explain the code changes if needed. |
Member
Author
|
bietkul
approved these changes
Apr 20, 2022
bietkul
added a commit
that referenced
this pull request
Apr 27, 2022
* fix: resolve conflicts * migrate to @react-google-maps/api * remove unwanted dependencies * feat: added MarkerWithLabel component * refactor: remove unused maps lib * refactor: remove unused props * fix: assign correct proptypes * fix: assign correct proptypes * feat: use mapKey from ReactiveBase to load maps script * fix(maps): load script onlywhen required for ReactiveGoogleMap * feat: added ScriptLoader HOC for google script loading * feat: use ScriptLoader HOC for google dependent components * fix(maps): GeoDistanceDropdown renderItem null handling * reset unwanted change * fix(maps): synchronise script loading mechanism for multiple components * feat: add redux support for script loading * feat(map): add libraries prop for reactivegooglemap to load different libraries * fix(maps): issue with exposing map instance to user * fix: script loading logic * fix(maps): labelAnchor offset reset to 0-0 * fix(maps): add null safety check for window object * fix(maps): use action creators instead of inline actions * fix(web): sync reactivecore package version * feat(Web): define mapLibraries prop in ReactiveBase * fix(maps): pass libraries prop as required * feat(maps): consume mapLibraries prop from config * fix(maps): remove redundant prop passing * sync submodules * fix: remove package-lock * feat(maps): render api changes for map components (#1925) * refactor(weB): import util methods from reactive lib * sync reactivecore post refacotring util methods * feat: accept render prop instead of renderAllData for ReactiveGoogleMap and ReactiveOpenStreet * fix: rename renderData prop to renderItem * reafctor(web): import util from reactivecore and update lib version * feat(maps): add onData callback event to GeoDistance-Dropdown/Slider * feat: add render and renderITem props * fix: render and renderItem prop usage for GeoDistanceDropdown * fix: GeoDistanceDropdown renderItem method to handle null condition * fix(maps): GeoDistanceDropdown renderItem null handling * fix(maps): api for GeoDistanceDropdown renderItem prop * v3.29.2-preview.1 * v3.1.0-preview.1 * v3.1.0-preview.2 * v3.1.0-preview.3 * v3.29.2-preview.2 * v3.29.2-preview.3 * fix(web): bad imports from wrong path * fix: versioining * fix(maps): revert package.json changes * fix(maps): ReactiveMap example package.json conflict resolution * fix: maps examples (#1928) * refactor(weB): import util methods from reactive lib * sync reactivecore post refacotring util methods * feat: accept render prop instead of renderAllData for ReactiveGoogleMap and ReactiveOpenStreet * fix: rename renderData prop to renderItem * reafctor(web): import util from reactivecore and update lib version * feat(maps): add onData callback event to GeoDistance-Dropdown/Slider * feat: add render and renderITem props * fix: render and renderItem prop usage for GeoDistanceDropdown * fix: GeoDistanceDropdown renderItem method to handle null condition * fix(maps): GeoDistanceDropdown renderItem null handling * fix(maps): GeoDistanceDropdown example * fix(maps): GeoDistanceSlider example * fix: airbeds site demo example * fix(maps): api for GeoDistanceDropdown renderItem prop * removed external google script calls from examples * fix: weather site demo * fix: polyline example * v3.29.2-preview.1 * v3.1.0-preview.1 * v3.1.0-preview.2 * v3.1.0-preview.3 * v3.29.2-preview.2 * v3.29.2-preview.3 * fix(web): bad imports from wrong path * sync with render-api changes * fix: versioining * fix(maps): revert package.json changes * fix(maps): ReactiveMap example package.json conflict resolution * fix(maps-examples): fix map examples with new api * add emotion dependency to meetup demo * chore: update sub packages * chore: update lock file * chore: upgrade reactivecore * fix(web): failing test case Co-authored-by: bietkul <kuldepsaxena155@gmail.com>
siddharthlatest
pushed a commit
that referenced
this pull request
Apr 29, 2022
* fix: resolve conflicts * migrate to @react-google-maps/api * remove unwanted dependencies * feat: added MarkerWithLabel component * refactor: remove unused maps lib * refactor: remove unused props * fix: assign correct proptypes * fix: assign correct proptypes * feat: use mapKey from ReactiveBase to load maps script * fix(maps): load script onlywhen required for ReactiveGoogleMap * feat: added ScriptLoader HOC for google script loading * feat: use ScriptLoader HOC for google dependent components * fix(maps): GeoDistanceDropdown renderItem null handling * reset unwanted change * fix(maps): synchronise script loading mechanism for multiple components * feat: add redux support for script loading * feat(map): add libraries prop for reactivegooglemap to load different libraries * fix(maps): issue with exposing map instance to user * fix: script loading logic * fix(maps): labelAnchor offset reset to 0-0 * fix(maps): add null safety check for window object * fix(maps): use action creators instead of inline actions * fix(web): sync reactivecore package version * feat(Web): define mapLibraries prop in ReactiveBase * fix(maps): pass libraries prop as required * feat(maps): consume mapLibraries prop from config * fix(maps): remove redundant prop passing * sync submodules * fix: remove package-lock * feat(maps): render api changes for map components (#1925) * refactor(weB): import util methods from reactive lib * sync reactivecore post refacotring util methods * feat: accept render prop instead of renderAllData for ReactiveGoogleMap and ReactiveOpenStreet * fix: rename renderData prop to renderItem * reafctor(web): import util from reactivecore and update lib version * feat(maps): add onData callback event to GeoDistance-Dropdown/Slider * feat: add render and renderITem props * fix: render and renderItem prop usage for GeoDistanceDropdown * fix: GeoDistanceDropdown renderItem method to handle null condition * fix(maps): GeoDistanceDropdown renderItem null handling * fix(maps): api for GeoDistanceDropdown renderItem prop * v3.29.2-preview.1 * v3.1.0-preview.1 * v3.1.0-preview.2 * v3.1.0-preview.3 * v3.29.2-preview.2 * v3.29.2-preview.3 * fix(web): bad imports from wrong path * fix: versioining * fix(maps): revert package.json changes * fix(maps): ReactiveMap example package.json conflict resolution * fix: maps examples (#1928) * refactor(weB): import util methods from reactive lib * sync reactivecore post refacotring util methods * feat: accept render prop instead of renderAllData for ReactiveGoogleMap and ReactiveOpenStreet * fix: rename renderData prop to renderItem * reafctor(web): import util from reactivecore and update lib version * feat(maps): add onData callback event to GeoDistance-Dropdown/Slider * feat: add render and renderITem props * fix: render and renderItem prop usage for GeoDistanceDropdown * fix: GeoDistanceDropdown renderItem method to handle null condition * fix(maps): GeoDistanceDropdown renderItem null handling * fix(maps): GeoDistanceDropdown example * fix(maps): GeoDistanceSlider example * fix: airbeds site demo example * fix(maps): api for GeoDistanceDropdown renderItem prop * removed external google script calls from examples * fix: weather site demo * fix: polyline example * v3.29.2-preview.1 * v3.1.0-preview.1 * v3.1.0-preview.2 * v3.1.0-preview.3 * v3.29.2-preview.2 * v3.29.2-preview.3 * fix(web): bad imports from wrong path * sync with render-api changes * fix: versioining * fix(maps): revert package.json changes * fix(maps): ReactiveMap example package.json conflict resolution * fix(maps-examples): fix map examples with new api * add emotion dependency to meetup demo * chore: update sub packages * chore: update lock file * chore: upgrade reactivecore * fix(web): failing test case Co-authored-by: bietkul <kuldepsaxena155@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Fix⭐Description The PR fixes the maps examples post the lib update to
@react-google-maps/api.📔 Notion
https://www.loom.com/share/55130ce498684b41a0f309187a06faad