Skip to content
This repository was archived by the owner on Aug 14, 2020. It is now read-only.

Documentation,scripts: add release instructions and bump-release script#137

Merged
iaguis merged 2 commits intoappc:masterfrom
kinvolk-archives:iaguis/release-instructions
Mar 10, 2016
Merged

Documentation,scripts: add release instructions and bump-release script#137
iaguis merged 2 commits intoappc:masterfrom
kinvolk-archives:iaguis/release-instructions

Conversation

@iaguis
Copy link
Copy Markdown
Member

@iaguis iaguis commented Mar 9, 2016

No description provided.

- Sanity check what the script did with `git diff HEAD^^` or similar.
- If the script didn't work, yell at the author and/or fix it.
It can almost certainly be improved.
- File a PR and get a review from another [MAINTAINER](https://github.com/appc/docker2aci/blob/master/MAINTAINERS).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAINTAINERS file needs to be updated.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, not on this PR though

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright.

@iaguis iaguis force-pushed the iaguis/release-instructions branch from c093410 to c23877b Compare March 9, 2016 22:07
@iaguis
Copy link
Copy Markdown
Member Author

iaguis commented Mar 9, 2016

Updated.

@krnowak
Copy link
Copy Markdown
Member

krnowak commented Mar 10, 2016

Roughly tested the release guide, seems to work. LFAD.

iaguis added a commit that referenced this pull request Mar 10, 2016
Documentation,scripts: add release instructions and bump-release script
@iaguis iaguis merged commit f1c9312 into appc:master Mar 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants