This repository was archived by the owner on Aug 14, 2020. It is now read-only.
lib: use upstream functions and parse digest#140
Merged
iaguis merged 2 commits intoappc:masterfrom Mar 16, 2016
Merged
Conversation
Now that we vendor, we can get rid of some copied code.
| } else { | ||
| indexName = nameParts[0] | ||
| remoteName = nameParts[1] | ||
| indexName, remoteName = name[:i], name[i+1:] |
Member
There was a problem hiding this comment.
This case will be visited also when i is -1, so you cannot use it for indexing, right?
Member
Author
There was a problem hiding this comment.
if i is -1 it will fall under the if condition, oder?
Member
|
One nit. Otherwise LFAD. |
iaguis
force-pushed
the
iaguis/docker-vendor
branch
from
1f980e6 to
2b7ecb2
Compare
iaguis
added a commit
that referenced
this pull request
Mar 16, 2016
lib: use upstream functions and parse digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we vendor, we can get rid of some copied code.
Also, this might help with rkt/rkt#2188
cc @dgonyeo