This repository was archived by the owner on Aug 14, 2020. It is now read-only.
change docker entrypoint/cmd annotations to json#142
Merged
iaguis merged 1 commit intoappc:masterfrom Mar 17, 2016
sjpotter:entrypoint-fix
Merged
change docker entrypoint/cmd annotations to json#142iaguis merged 1 commit intoappc:masterfrom sjpotter:entrypoint-fix
iaguis merged 1 commit intoappc:masterfrom
sjpotter:entrypoint-fix
Conversation
Contributor
Author
Contributor
|
LGTM |
Contributor
Member
|
Can you prefix the commit message with "lib/internal:"? This is just so the users can inspect how the original image was, right? |
Member
I'll answer myself: yes (I just checked the original PR for these annotations). LGTM after changing the commit message |
| if err != nil { | ||
| return nil, err | ||
| } | ||
| annotations = append(annotations, appctypes.Annotation{Name: *appctypes.MustACIdentifier(common.AppcDockerCmd), Value: string(cmd)}) |
Member
There was a problem hiding this comment.
Weird, I wonder why Value is colored here and not above...
can't serialize them with a join as exec arguments can have a space
iaguis
added a commit
that referenced
this pull request
Mar 17, 2016
change docker entrypoint/cmd annotations to json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can't serialize them with a join as exec arguments can have a space