This repository was archived by the owner on Aug 14, 2020. It is now read-only.
spec/discovery: remove Simple Discovery entirely#559
Merged
jonboulle merged 1 commit intoappc:masterfrom Jan 6, 2016
Merged
Conversation
The value of Simple Discovery has always been somewhat dubious, and most implementations of the spec (`apcera/kurma`, `3ofcoins/jetpack`, `coreos/rkt`) never actually implemented it. On the other hand, meta discovery is used actively and arguably is synonymous with discovery. This PR proposes removing the concept of Simple Discovery entirely and making that synonymousness official - i.e., App Container Image Discovery is what was formerly called Meta Discovery. References: appc#56 appc#140 appc#118 rkt/rkt#383
Member
|
LGTM. We'd implemented meta discovery, but never did simple discovery. Meta was just far more thorough. |
jonboulle
added a commit
that referenced
this pull request
Jan 6, 2016
spec/discovery: remove Simple Discovery entirely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of Simple Discovery has always been somewhat dubious, and most
implementations of the spec (
apcera/kurma,3ofcoins/jetpack,coreos/rkt) never actually implemented it. On the other hand, metadiscovery is used actively and arguably is synonymous with discovery.
This PR proposes removing the concept of Simple Discovery entirely and
making that synonymousness official - i.e., App Container Image
Discovery is what was formerly called Meta Discovery.
References:
#56
#140
#118
rkt/rkt#383
/cc @philips @krobertson