APIGOV-32698 Engage CLI - Add Unit Testing#289
Merged
Conversation
kasuvy
requested review from
jcollins-axway,
jquick-axway,
nboxhallburnett,
sbolosan and
vivekschauhan
Contributor
Author
|
Merging this as the Engage Unit Tests suite is passing. Will include this in the review that has been open for the whole refactoring - #288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated unit tests for the engage related commands. We have rewrite the tests as the old tests were using "sinon" as the stubbing library which now doesn't support ESM. The new test suite uses "testdouble.js" library for stubbing various modules.
https://www.npmjs.com/package/testdouble
Also, the new engage units tests are aligned with the other Axway CLI tests that spawns a test server to run the tests. It uses mushtache templates to make various test assertions for all the commands.