Fix: escape vcvarsall before subprocess.run#25
Merged
sgtcoolguy merged 1 commit intoappcelerator-archive:masterfrom Oct 29, 2015
infosia:cert_vcvars
Merged
Fix: escape vcvarsall before subprocess.run#25sgtcoolguy merged 1 commit intoappcelerator-archive:masterfrom infosia:cert_vcvars
sgtcoolguy merged 1 commit intoappcelerator-archive:masterfrom
infosia:cert_vcvars
Conversation
Fix: Stop using /m at msbuild
sgtcoolguy
added a commit
that referenced
this pull request
Oct 29, 2015
Fix: escape vcvarsall before subprocess.run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vcvarsallatsubprocess.runSpaces in
vcvarsallshould be escaped insubprocess.runwhen it is used with&&, it may cause error when both Visual Studio 2013 and 2015 are installed. Also, stop using/mat MsBuild due to TIMOB-19646.@sgtcoolguy, could you bump up the version and update titanium_mobile so that it points to the new version? Thanks.