Temporary fix for missing callback on rails_db gem #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelaniwoods
approved these changes
Jun 5, 2024
Contributor
jelaniwoods
left a comment
jelaniwoods
left a comment
There was a problem hiding this comment.
This looks like an acceptable work around for now since before actions aren't really used until devise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on resurrecting the
dev_toolbargem, I happened across an issue for the (very popular with our beginners) show-stopper bug in therails_dbgem for Rails v7.1: igorkasyanchuk/rails_db#134I opened a teeny, tiny PR to fix that Gem (igorkasyanchuk/rails_db#139; my first open-source Ruby / Rails contribution 🥳 )
There is not so much activity on that Gem page though, so as a workaround to allow
/rails/dbto function ASAP, we can just disable the default Rails 7.1 setting (in development only, shouldn't affect anything as we don't use callbacks much right now in the Phase 1 or 2 content?)We can revert this commit when the
rails_dbGem update is made (I'll make a note of it).