Update various string resources for consistency and clarity#1054
Update various string resources for consistency and clarity#1054hal-eisen-adfa merged 2 commits intostagefrom
Conversation
Elissa-AppDevforAll
commented
Mar 9, 2026
- Beefed up the permissions descriptions so we can remove the intermediary page.
- Rewrote the hint that shows when the user can't enable Display over other app--the issue isn't limited just to Pixel phones.
- Changed debugger-pairing success message from "yada Shizuku yada" to provide instructions to return to Code on the Go.
- Removed some incorrect capital letters.
- Fixed typographical problems.
Beefed up the permissions descriptions so we can remove the intermediary page. Rewrote the hint that shows when the user can't enable Display over other app--the issue isn't limited just to Pixel phones Removed some incorrect capital letters. Fixed typographical problems.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 Walkthrough
Risks and best-practice considerations:
WalkthroughThis PR updates text in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
resources/src/main/res/values/strings.xml (1)
692-692: The hint is clearer but consider consistency with line 701.The rewritten hint removes device-specific assumptions effectively. However, line 701 (
permissions_info_overlay_accessibility) uses a different navigation phrase: "go to Settings → Apps → Code on the Go" vs. this line's "display App info for Code on the Go."Both reach the same destination, but if these strings might be shown in the same user journey, consider aligning the wording. If they appear in different contexts (line 692 via
flashError()per the context snippet, line 701 in onboarding), the variation may be acceptable.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@resources/src/main/res/values/strings.xml` at line 692, The two related string resources are inconsistent in navigation phrasing: update the string named permission_overlay_restricted_settings_hint to match the phrasing used in permissions_info_overlay_accessibility (or vice versa) so both use the same navigation style (e.g., "Go to Settings → Apps → Code on the Go, tap the three-dot menu, and enable restricted settings.") to ensure consistent user guidance across onboarding and flashError() flows.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@resources/src/main/res/values/strings.xml`:
- Line 692: The two related string resources are inconsistent in navigation
phrasing: update the string named permission_overlay_restricted_settings_hint to
match the phrasing used in permissions_info_overlay_accessibility (or vice
versa) so both use the same navigation style (e.g., "Go to Settings → Apps →
Code on the Go, tap the three-dot menu, and enable restricted settings.") to
ensure consistent user guidance across onboarding and flashError() flows.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1a1b8957-62cb-40e2-8179-527985d8eb8d
📒 Files selected for processing (1)
resources/src/main/res/values/strings.xml