Skip to content

Update various string resources for consistency and clarity#1054

Merged
hal-eisen-adfa merged 2 commits intostagefrom
ADFA-2843-Expand-text-for-each-permission-on-page
Apr 1, 2026
Merged

Update various string resources for consistency and clarity#1054
hal-eisen-adfa merged 2 commits intostagefrom
ADFA-2843-Expand-text-for-each-permission-on-page

Conversation

@Elissa-AppDevforAll
Copy link
Copy Markdown
Collaborator

  • Beefed up the permissions descriptions so we can remove the intermediary page.
  • Rewrote the hint that shows when the user can't enable Display over other app--the issue isn't limited just to Pixel phones.
  • Changed debugger-pairing success message from "yada Shizuku yada" to provide instructions to return to Code on the Go.
  • Removed some incorrect capital letters.
  • Fixed typographical problems.

Beefed up the permissions descriptions so we can remove the intermediary page. 

Rewrote the hint that shows when the user can't enable Display over other app--the issue isn't limited just to Pixel phones

Removed some incorrect capital letters. 

Fixed typographical problems.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6e85e9a2-89cc-44ce-9507-8df5aff9f8ae

📥 Commits

Reviewing files that changed from the base of the PR and between 3f76697 and d31f517.

📒 Files selected for processing (1)
  • resources/src/main/res/values/strings.xml
✅ Files skipped from review due to trivial changes (1)
  • resources/src/main/res/values/strings.xml

📝 Walkthrough
  • Permission descriptions expanded for clarity:

    • Storage: "access files." → "open and save files on this device."
    • Install packages: "install apps that you build." → "install the apps that you build on this device."
    • Floating debugger (was "Overlay window"):
      • Title: "Overlay window" → "Floating debugger"
      • Description: "overlay windows over other apps." → "display floating debugger controls to inspect your code while it runs."
      • Restriction/hint text rewritten to remove Pixel-only implication and clarify the workflow if the permission cannot be enabled.
    • Notifications permission: "post notifications." → "display notifications."
  • UI text and punctuation standardization:

    • Plugin wizard fields: title case → sentence case for wizard_plugin_name, wizard_plugin_id, wizard_plugin_author.
    • Removed trailing exclamation in copied confirmation (e.g., "Copied successfully!" → "Copied successfully").
    • Build messages and labels adjusted:
      • build_in_progress_warning: "Build is already…" → "A build is already…"
      • build_status_failed wording updated to reference "Build Output" (capitalization).
      • title_cpu_arch → "CPU arch"
      • title_restart_required → "Restart required"
      • btn_restart_now → "Restart now"
    • Typographical fixes and removal of incorrect capital letters across strings.
  • Debugger pairing / notification message change:

    • notification_adb_pairing_succeed_text changed from an informal placeholder about starting Shizuku to a clear navigation instruction: "Tap the Back button to return to Code on the Go."
  • Public API / exported symbols:

    • No API or public/exported declarations were changed — only Android string resources.

Risks and best-practice considerations:

  • Localization: Update translations for all locales to avoid untranslated strings.
  • Layout: Longer permission descriptions may require UI checks to avoid truncation or layout issues on different devices/orientations.
  • Terminology consistency: Renaming "Overlay window" → "Floating debugger" should be reconciled with documentation, help text, and marketing.
  • Navigation accuracy: Confirm the new debugger-pairing instruction matches the actual app navigation flow.
  • Design consistency: Verify sentence-case and capitalization choices align with the app's style guide and Material Design guidelines.

Walkthrough

This PR updates text in resources/src/main/res/values/strings.xml: adjusts capitalization and casing for plugin wizard and UI labels, refines build/notification messages, and rewords permission titles and descriptions (including renaming overlay permission to "Floating debugger").

Changes

Cohort / File(s) Summary
Plugin Wizard & UI Labels
resources/src/main/res/values/strings.xml
Changed casing for plugin wizard fields and UI labels: wizard_plugin_name, wizard_plugin_id, wizard_plugin_author → sentence case; title_cpu_arch, title_restart_required, btn_restart_now adjusted to lowercase-style wording.
Build / Notification Messages
resources/src/main/res/values/strings.xml
Refined user messages: removed trailing exclamation in copied, updated build_status_failed to reference "Build Output", tweaked build_in_progress_warning, and revised ADB pairing success text to navigation instruction.
Permission Titles & Descriptions
resources/src/main/res/values/strings.xml
Reworded permission texts: storage/install descriptions clarified ("open and save" / "install the apps that you build on this device"); permission_title_overlay_window renamed to "Floating debugger" with matching description and restricted-settings hint; notifications wording changed to "display notifications".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • jatezzz
  • davidschachterADFA

Poem

🐰✨ Tiny changes, tidy rows,
Words aligned where UI flows.
"Floating debugger" takes its place,
Permissions polished, clear and ace.
A small hop, a joyful cheer—strings fixed, the screen is dear! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating string resources for consistency and clarity, which is exactly what the changeset does.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale behind permission description expansion, hint rewording, message changes, and capitalization/typo fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-2843-Expand-text-for-each-permission-on-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
resources/src/main/res/values/strings.xml (1)

692-692: The hint is clearer but consider consistency with line 701.

The rewritten hint removes device-specific assumptions effectively. However, line 701 (permissions_info_overlay_accessibility) uses a different navigation phrase: "go to Settings → Apps → Code on the Go" vs. this line's "display App info for Code on the Go."

Both reach the same destination, but if these strings might be shown in the same user journey, consider aligning the wording. If they appear in different contexts (line 692 via flashError() per the context snippet, line 701 in onboarding), the variation may be acceptable.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@resources/src/main/res/values/strings.xml` at line 692, The two related
string resources are inconsistent in navigation phrasing: update the string
named permission_overlay_restricted_settings_hint to match the phrasing used in
permissions_info_overlay_accessibility (or vice versa) so both use the same
navigation style (e.g., "Go to Settings → Apps → Code on the Go, tap the
three-dot menu, and enable restricted settings.") to ensure consistent user
guidance across onboarding and flashError() flows.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@resources/src/main/res/values/strings.xml`:
- Line 692: The two related string resources are inconsistent in navigation
phrasing: update the string named permission_overlay_restricted_settings_hint to
match the phrasing used in permissions_info_overlay_accessibility (or vice
versa) so both use the same navigation style (e.g., "Go to Settings → Apps →
Code on the Go, tap the three-dot menu, and enable restricted settings.") to
ensure consistent user guidance across onboarding and flashError() flows.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a1b8957-62cb-40e2-8179-527985d8eb8d

📥 Commits

Reviewing files that changed from the base of the PR and between 5a56a46 and 3f76697.

📒 Files selected for processing (1)
  • resources/src/main/res/values/strings.xml

@hal-eisen-adfa hal-eisen-adfa merged commit 90bfbcf into stage Apr 1, 2026
2 checks passed
@hal-eisen-adfa hal-eisen-adfa deleted the ADFA-2843-Expand-text-for-each-permission-on-page branch April 1, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants