Skip to content

ADFA-3269 Removing telegram debug info#1079

Merged
hal-eisen-adfa merged 1 commit intostagefrom
ADFA-3269-remove-debug
Mar 14, 2026
Merged

ADFA-3269 Removing telegram debug info#1079
hal-eisen-adfa merged 1 commit intostagefrom
ADFA-3269-remove-debug

Conversation

@hal-eisen-adfa
Copy link
Collaborator

The root cause of the problem was a trailing newline in the TELEGRAM_TOKEN secret

@hal-eisen-adfa hal-eisen-adfa merged commit 5034825 into stage Mar 14, 2026
1 of 2 checks passed
@hal-eisen-adfa hal-eisen-adfa deleted the ADFA-3269-remove-debug branch March 14, 2026 00:08
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a67be0fc-692c-4944-a5b2-2350bf74f752

📥 Commits

Reviewing files that changed from the base of the PR and between 78b1f8c and 5b53483.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Release Notes

  • Enabled workflow_dispatch trigger in the release workflow, allowing manual triggering of the build process
  • Removed "Verify Telegram token" step from the Build Release APK workflow
  • Removed debug output command that used od -c to print the Telegram message payload

Security Considerations

⚠️ Positive Security Improvement: Removing debug commands that echoed sensitive Telegram API communication is a best practice to prevent accidental exposure of secrets or token information in workflow logs.

Walkthrough

The release workflow configuration was updated to enable manual triggering via workflow_dispatch, remove the Telegram token verification step, and eliminate a debugging print statement from the Telegram messaging step.

Changes

Cohort / File(s) Summary
GitHub Actions Release Workflow
.github/workflows/release.yml
Enabled workflow_dispatch trigger, removed Telegram token verification step, and removed debugging od -c print statement from Telegram messaging step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Workflows now flow with a manual touch,
No tokens to verify, no debug clutter,
The pipeline purrs, streamlined and clean,
A dispatch away from the smoothest release scene!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ADFA-3269-remove-debug
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant