ADFA-3350 | Refactor main screen actions to use ActionsRegistry#1091
Merged
jatezzz merged 3 commits intofeat/ADFA-3153-ide-shortcut-systemfrom Mar 19, 2026
Merged
Conversation
refactor(shortcuts): route main screen actions through registry and update bindings
…3350-main-shortcuts
itsaky-adfa
requested changes
Mar 19, 2026
Contributor
itsaky-adfa
left a comment
itsaky-adfa
left a comment
There was a problem hiding this comment.
Requires minor, good-to-have changes. Looks good otherwise.
app/src/main/java/com/itsaky/androidide/shortcuts/IdeShortcutActions.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/itsaky/androidide/shortcuts/IdeShortcutActions.kt
Outdated
Show resolved
Hide resolved
… visibility Add logs for missing action data, registry mismatch, and unresolved action IDs to avoid silent failures
itsaky-adfa
approved these changes
Mar 19, 2026
jatezzz
added a commit
that referenced
this pull request
Mar 20, 2026
* fix(main): refresh main screen actions on resume refactor(shortcuts): route main screen actions through registry and update bindings * refactor: migrate shortcut actions logging to SLF4J and improve error visibility Add logs for missing action data, registry mismatch, and unresolved action IDs to avoid silent failures
jatezzz
added a commit
that referenced
this pull request
Mar 20, 2026
* feat(shortcuts): introduce modular IDE shortcut catalog and execution system add grouped shortcuts and editor dispatch integration * fix(shortcuts): correct priority scoring using only active contexts refactor(shortcuts): rename saveFile to saveAllFiles for consistency * fix: guard `childFragmentManager` access before recursion. * ADFA-3350 | Refactor main screen actions to use ActionsRegistry (#1091) * fix(main): refresh main screen actions on resume refactor(shortcuts): route main screen actions through registry and update bindings * refactor: migrate shortcut actions logging to SLF4J and improve error visibility Add logs for missing action data, registry mismatch, and unresolved action IDs to avoid silent failures * refactor: extract `.main` shortcut IDs into `ShortcutDefinitionIds`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the main screen actions to route through the centralized
ActionsRegistryrather than relying on the hardcodedMainScreenActionmodel. It introduces individualActionItemimplementations (such asCreateProjectAction,OpenProjectAction,OpenTerminalAction, etc.) for better modularity. Additionally, it updates the shortcut definitions to bind directly to these new action IDs and ensures that the main screen actions are properly refreshed inonResume.Details
Logic refactor applied to action handling and shortcut bindings. The visual representation of the main screen buttons remains consistent, but their underlying click/long-click handling is now driven by the
DefaultActionsRegistry.document_5033170361982650184.mp4
Ticket
ADFA-3350
Observation
Removed legacy classes
MainScreenAction.ktandShortcutActionIds.ktas their responsibilities have been fully migrated to the new individual action classes. Fallback logic inIdeShortcutActionswas also cleaned up since actions are natively resolved through the registry now.