fix/ADFA-3549 compose logsender runtime error

[jomen-adfa]

fix error cause by invalid reference to ic_delete

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0ca6ce48-718c-425d-b7b1-2590aadacc65

📥 Commits

Reviewing files that changed from the base of the PR and between 567a4b0 and 5c4b7cf.

📒 Files selected for processing (1)

• logsender/src/main/java/com/itsaky/androidide/logsender/LogSenderService.java

---

📝 Walkthrough

Release Notes

• Fixed runtime error in LogSenderService: Corrected invalid drawable reference in the notification "Exit" action by replacing the non-existent app resource R.drawable.ic_delete with the framework-provided android.R.drawable.ic_delete
• Notification UI adjustment: The "Exit" button in the LogSenderService notification now uses the standard Android delete icon

Risk Assessment: Low risk fix - minimal single-line change affecting only the notification action button icon, using a standard Android framework resource

Walkthrough

Updated the notification "Exit" action icon from an app-specific drawable resource to a framework-provided drawable. This change affects the visual appearance of the exit action in the LogSender service notification.

Changes

Cohort / File(s)	Summary
Notification Icon Resource logsender/src/main/java/com/itsaky/androidide/logsender/LogSenderService.java	Changed notification exit action icon from R.drawable.ic_delete to android.R.drawable.ic_delete, using Android's framework drawable instead of app resource.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A delete icon so small, now swapped with care,
From app resources to Android's framework fair,
One line adjusted, the notification shines bright,
The exit button now uses the system's might! 🎨✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title references 'compose logsender runtime error' which aligns with the changeset's fix for an invalid drawable reference causing a runtime error in LogSenderService.
Description check	✅ Passed	The description 'fix error cause by invalid reference to ic_delete' directly relates to the changeset, which fixes an invalid ic_delete drawable reference.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ADFA-3549-compose-logsender-crash

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}