ADFA-2488: Fix strictmode disk validation error on sample plugin

[Daniel-ADFA]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@Daniel-ADFA has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 51 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 51 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 11baa5bb-a00b-47c8-a0c2-006d7e333f3e

📥 Commits

Reviewing files that changed from the base of the PR and between 72fe1f9 and 9d713d8.

📒 Files selected for processing (2)

• plugin-api/src/main/kotlin/com/itsaky/androidide/plugins/extensions/BuildActionExtension.kt
• plugin-manager/src/main/kotlin/com/itsaky/androidide/plugins/manager/build/PluginBuildActionManager.kt

📝 Walkthrough

Walkthrough

Two focused changes: (1) ProjectHandlerActivity now calls invalidateOptionsMenu() after project initialization completes to refresh the options menu state; (2) IProjectManager.isPluginProject() simplified to return cached value directly without performing filesystem existence checks.

Changes

Cohort / File(s)	Summary
Menu Refresh app/src/main/java/com/itsaky/androidide/activities/editor/ProjectHandlerActivity.kt	Added invalidateOptionsMenu() call immediately after completing project initialization to ensure menu items reflect updated state.
Plugin Detection Simplification subprojects/projects/src/main/java/com/itsaky/androidide/projects/IProjectManager.kt	Removed filesystem existence check logic from isPluginProject(). Now returns cached pluginProjectCached value directly; eliminated Environment import and caching computation from projectDir + PLUGIN_API_JAR_RELATIVE_PATH path checks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A menu refreshes, clean and bright,

Plugin checks now cached just right,

No filesystem wandering today,

Simpler code in every way! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a pull request description explaining the changes made and the rationale behind removing the filesystem existence checks.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly references the ticket identifier and describes the main fix: removing strictmode disk validation errors related to sample plugins, which aligns with the filesystem check removal in IProjectManager.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-2488

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}