ADFA-3581: add custom analysis API services and source file index by itsaky-adfa · Pull Request #1180 · appdevforall/CodeOnTheGo

itsaky-adfa · 2026-04-14T19:16:42Z

See ADFA-3581 for more details.

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…dency

fixes duplicate class errors for org.antrl.v4.* classes Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

It is now included in the embeddable JAR (named UnsafeAndroid) with proper relocations. Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…ject re-sync Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Handles document events to manage instances of in-memory KtFile that can be used by various Kt LSP components (like diagnostics provider, code completions) to re-use already parsed KtFile instances Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

This ensures that extension functions whose receiver type is not available in the current scope are not suggested for scope completions Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

The StandaloneProjectFactory takes care of setting up a special MockProject instance which allows us to use Intellij's MessageBus to notify the analysis API about file changes. Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…odules Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Libraries are already indexed by JvmLibraryIndexingService Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

This indexed is *always* refreshed after every successful build Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…tions

…feat/ADFA-3581-source-index

coderabbitai · 2026-04-20T20:32:36Z

Warning

Rate limit exceeded

@itsaky-adfa has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 36 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 36 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 750da21f-a223-458b-ac1a-cac275827768

📥 Commits

Reviewing files that changed from the base of the PR and between df351e6 and 81f403d.

📒 Files selected for processing (77)

app/src/main/java/com/itsaky/androidide/app/IDEApplication.kt
common/build.gradle.kts
common/src/main/java/com/itsaky/androidide/utils/Environment.java
composite-builds/build-deps/java-compiler/src/main/java/com/itsaky/androidide/javac/config/JavacConfigProvider.java
logger/src/main/java/com/itsaky/androidide/logging/IDELoggingConfigurator.kt
lsp/indexing/src/main/kotlin/org/appdevforall/codeonthego/indexing/FilteredIndex.kt
lsp/indexing/src/main/kotlin/org/appdevforall/codeonthego/indexing/InMemoryIndex.kt
lsp/indexing/src/main/kotlin/org/appdevforall/codeonthego/indexing/MergedIndex.kt
lsp/indexing/src/main/kotlin/org/appdevforall/codeonthego/indexing/SQLiteIndex.kt
lsp/indexing/src/main/kotlin/org/appdevforall/codeonthego/indexing/api/Index.kt
lsp/indexing/src/main/kotlin/org/appdevforall/codeonthego/indexing/service/IndexingService.kt
lsp/indexing/src/main/kotlin/org/appdevforall/codeonthego/indexing/service/IndexingServiceManager.kt
lsp/indexing/src/main/kotlin/org/appdevforall/codeonthego/indexing/util/BackgroundIndexer.kt
lsp/java/src/main/java/com/itsaky/androidide/lsp/java/JavaLanguageServer.kt
lsp/jvm-symbol-index/build.gradle.kts
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/CombinedJarScanner.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/JarSymbolScanner.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/JvmGeneratedIndexingService.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/JvmLibraryIndexingService.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/JvmLibrarySymbolIndex.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/JvmSymbol.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/JvmSymbolIndex.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/KotlinMetadataScanner.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/KtFileMetadata.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/KtFileMetadataDescriptor.kt
lsp/jvm-symbol-index/src/main/kotlin/org/appdevforall/codeonthego/indexing/jvm/KtFileMetadataIndex.kt
lsp/jvm-symbol-models/src/main/proto/jvm_symbol.proto
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/KotlinLanguageServer.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/KtFileManager.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/CompilationEnvironment.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/Compiler.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/KotlinProjectModel.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/ModuleResolver.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/ReadWriteLock.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/WorkspaceExts.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/index/IndexCommand.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/index/IndexWorker.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/index/KtSymbolIndex.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/index/ScanningWorker.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/index/SourceFileIndexer.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/index/WorkerQueue.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/modules/AbstractKtModule.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/modules/KtFileExts.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/modules/KtLibraryModule.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/modules/KtModule.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/modules/KtSourceModule.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/modules/NotUnderContentRootModule.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/registrar/LspServiceRegistrar.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/AnalysisPermissionOptions.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/AnnotationsResolver.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/DeclarationsProvider.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/DirectInheritorsProvider.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/JavaModuleAccessibilityChecker.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/JavaModuleAnnotationsProvider.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/KtLspService.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/LanguageSettings.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/ModificationTrackerFactory.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/ModuleDependentsProvider.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/NoOpAsyncExecutionService.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/PackageProvider.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/PlatformSettings.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/ProjectStructureProvider.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/compiler/services/WriteAccessGuard.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/completion/AdvancedKotlinEditHandler.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/completion/KotlinClassImportEditHandler.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/completion/KotlinCompletions.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/completion/SymbolVisibilityChecker.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/diagnostic/KotlinDiagnosticProvider.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/utils/SymbolVisibilityChecker.kt
lsp/kotlin/src/main/java/com/itsaky/androidide/lsp/kotlin/utils/VirtualFileExts.kt
lsp/kotlin/src/main/resources/META-INF/kt-lsp/kt-lsp.xml
subprojects/kotlin-analysis-api/build.gradle.kts
subprojects/project-models/src/main/proto/android.proto
subprojects/project-models/src/main/proto/common.proto
subprojects/project-models/src/main/proto/java.proto
subprojects/tooling-api-impl/src/main/java/com/itsaky/androidide/tooling/impl/serial/AndroidProjectExts.kt
subprojects/tooling-api-impl/src/main/java/com/itsaky/androidide/tooling/impl/serial/JavaProjectExts.kt

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/ADFA-3581-source-index

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa added 30 commits March 19, 2026 22:07

fix: add ability to re-write class name references in desugar plugin

1b069cb

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: integrate Kotlin analysis API

a70fd66

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Merge branch 'stage' into fix/ADFA-3366-include-analysis-api-as-depen…

4ca1e97

…dency

fix: update kotlin-android to latest version

43286a6

fixes duplicate class errors for org.antrl.v4.* classes Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: remove UnsafeImpl

f1fe62f

It is now included in the embeddable JAR (named UnsafeAndroid) with proper relocations. Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: update kotlin-android to latest version

6e6d8b3

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: replace usages of Unsafe with UnsafeImpl

b208658

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: make Kotlin LSP no-op

c844ad2

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: configure K2 standalone session when setting up LSP

58db2cb

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: JvmTarget resolution fails for input "21"

bf7acd1

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: do not early-init VirtualFileSystem

dc62a51

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: remove replaceClass desugar instruction for Unsafe

4b1c8e4

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: ensure boot class path is added as dependency to Android modules

b14f6ee

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add diagnostic provider for Kotlin

54ca7a9

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: remove unnecessary log statement

6e4d458

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: update to latest kotlin-android release

5d841a3

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: always re-initialize K2 session on setupWithProject

4b7b0f2

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: diagnostics are always collected from the on-disk file

e2f137a

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add the ability to incrementally invalidate source roots on pro…

09fc9ea

…ject re-sync Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: dispatch build-related events from GradleBuildService

dd3d519

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: introduct KtFileManager

d6defa6

Handles document events to manage instances of in-memory KtFile that can be used by various Kt LSP components (like diagnostics provider, code completions) to re-use already parsed KtFile instances Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: add initial K2-backed scope code completions

4666893

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add member completions backed by K2

2f982a7

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: suggest local and imported extension functions

4129a47

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: do not suggest extension functions for scope completions

7d736fa

This ensures that extension functions whose receiver type is not available in the current scope are not suggested for scope completions Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add scope-sensitive keyword completions

87234f8

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add indexing api and service implementation

7d78db1

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: metadata version is sometimes not parsed

c35aa9f

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: make JvmSymbolIndex exclusive to external libraries

bede4db

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add module resolver to resolve library modules from source path

9eb4ffe

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa added 16 commits April 9, 2026 12:31

fix: auto-import un-imported classes

47d1738

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: use internal name repr for library index

eed2d03

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: filter-out ext syms with inapplicable receivers

e6fcf6e

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add Kotlin source file index

9fa3d4a

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: infinite loop when converting type names to display names

ab5c7d9

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: update ModuleResolver to resolve KaSourceModule from file path

0ec7b4b

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: update KotlinSourceScanner to use internal names in index

bf9b2da

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add custom implementations of analysis API services

49e7efe

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add support for indexing classes using VirtualFile

51d0686

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: create in-memory KtFile instances for modified files

e77df48

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: IndexWorker always re-index libraries

340b08b

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add KtFile.backingFilePath for better resolution of declaring m…

a1d999e

…odules Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: remove library indexing logic for kt index worker

49542ad

Libraries are already indexed by JvmLibraryIndexingService Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add index for generated JARs

888193f

This indexed is *always* refreshed after every successful build Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: java source files are not recognized by analysis API

f3997a5

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa requested a review from a team April 14, 2026 19:16

itsaky-adfa self-assigned this Apr 14, 2026

itsaky-adfa changed the base branch from stage to feat/ADFA-3320-non-imported-ext-func-completions April 15, 2026 04:38

itsaky-adfa marked this pull request as ready for review April 15, 2026 04:38

chore: trigger ci

bcbbba3

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

jatezzz approved these changes Apr 20, 2026

View reviewed changes

itsaky-adfa added 2 commits April 21, 2026 01:53

Merge branch 'stage' into feat/ADFA-3320-non-imported-ext-func-comple…

d109866

…tions

Merge branch 'feat/ADFA-3320-non-imported-ext-func-completions' into …

083388b

…feat/ADFA-3581-source-index

Base automatically changed from feat/ADFA-3320-non-imported-ext-func-completions to stage April 20, 2026 20:31

Merge branch 'stage' into feat/ADFA-3581-source-index

26406cc

fix: remove unused duplicate file

81f403d

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa merged commit fa7676d into stage Apr 20, 2026
2 checks passed

itsaky-adfa deleted the feat/ADFA-3581-source-index branch April 20, 2026 20:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADFA-3581: add custom analysis API services and source file index#1180

ADFA-3581: add custom analysis API services and source file index#1180
itsaky-adfa merged 53 commits intostagefrom
feat/ADFA-3581-source-index

itsaky-adfa commented Apr 14, 2026 •

edited by atlassian Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 20, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

itsaky-adfa commented Apr 14, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

itsaky-adfa commented Apr 14, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Apr 20, 2026 •

edited

Loading