ADFA-3721: remove unused kotlin lsp modules by itsaky-adfa · Pull Request #1184 · appdevforall/CodeOnTheGo

itsaky-adfa · 2026-04-15T06:37:34Z

See ADFA-3721 for more details.

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…dency

fixes duplicate class errors for org.antrl.v4.* classes Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

It is now included in the embeddable JAR (named UnsafeAndroid) with proper relocations. Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…ject re-sync Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Handles document events to manage instances of in-memory KtFile that can be used by various Kt LSP components (like diagnostics provider, code completions) to re-use already parsed KtFile instances Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

This ensures that extension functions whose receiver type is not available in the current scope are not suggested for scope completions Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

The StandaloneProjectFactory takes care of setting up a special MockProject instance which allows us to use Intellij's MessageBus to notify the analysis API about file changes. Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…odules Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Libraries are already indexed by JvmLibraryIndexingService Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

This indexed is *always* refreshed after every successful build Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…tions

…feat/ADFA-3581-source-index

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

…unused-modules

coderabbitai · 2026-04-20T20:58:48Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e2c612e6-d796-49aa-a11a-85eba70294a3

📥 Commits

Reviewing files that changed from the base of the PR and between fa7676d and 883f871.

📒 Files selected for processing (57)

lsp/jvm-symbol-index/build.gradle.kts
lsp/kotlin-core/build.gradle.kts
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/ClasspathIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/ClasspathIndexer.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/DependencyTracker.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/ExtensionIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/FileIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/IndexEntry.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/PackageIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/ProjectIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/StdlibIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/StdlibIndexLoader.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/SymbolIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/KotlinParser.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/ParseResult.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/Position.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/PositionConverter.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/SyntaxKind.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/SyntaxNode.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/SyntaxTree.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/SyntaxVisitor.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/TextRange.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/AnalysisContext.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/Diagnostic.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/OverloadResolver.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/SemanticAnalyzer.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/SymbolResolver.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/TypeInferrer.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/AnalysisCache.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/AnalysisScheduler.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/DocumentManager.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/DocumentState.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/KotlinLanguageServer.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/KotlinTextDocumentService.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/KotlinWorkspaceService.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/CodeActionProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/CompletionProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/DefinitionProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/DiagnosticProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/DocumentSymbolProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/HoverProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/SemanticTokenProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/Modifiers.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/Scope.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/ScopeKind.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/Symbol.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/SymbolBuilder.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/SymbolLocation.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/SymbolTable.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/SymbolVisitor.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/Visibility.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/types/KotlinType.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/types/TypeChecker.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/types/TypeResolver.kt
lsp/kotlin-stdlib-generator/build.gradle.kts
lsp/kotlin-stdlib-generator/src/main/kotlin/org/appdevforall/codeonthego/lsp/kotlin/generator/StdlibIndexGenerator.kt
settings.gradle.kts

💤 Files with no reviewable changes (51)

lsp/jvm-symbol-index/build.gradle.kts
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/HoverProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/StdlibIndexLoader.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/TypeInferrer.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/SymbolResolver.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/DocumentSymbolProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/Visibility.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/Position.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/ScopeKind.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/KotlinParser.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/SemanticTokenProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/SymbolLocation.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/SymbolBuilder.kt
lsp/kotlin-core/build.gradle.kts
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/SyntaxTree.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/PositionConverter.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/ProjectIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/SyntaxKind.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/DocumentState.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/CompletionProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/SemanticAnalyzer.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/DefinitionProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/DiagnosticProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/PackageIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/DependencyTracker.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/AnalysisScheduler.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/SymbolTable.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/providers/CodeActionProvider.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/DocumentManager.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/TextRange.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/SyntaxNode.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/ExtensionIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/IndexEntry.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/ClasspathIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/AnalysisContext.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/ParseResult.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/Scope.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/AnalysisCache.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/ClasspathIndexer.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/OverloadResolver.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/FileIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/SymbolVisitor.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/Modifiers.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/SyntaxVisitor.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/StdlibIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/Diagnostic.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/SymbolIndex.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/KotlinTextDocumentService.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/KotlinWorkspaceService.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/KotlinLanguageServer.kt
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/Symbol.kt

📝 Walkthrough

Release Notes: Removal of Kotlin LSP Modules (ADFA-3721)

Summary

Completely removes the Kotlin Language Server Protocol (LSP) implementation from the codebase, including the entire lsp/kotlin-core module and its associated dependencies. This is a comprehensive cleanup of unused Kotlin language server functionality that is no longer maintained or utilized.

Changes Removed

Kotlin Core Module (lsp/kotlin-core/):

Kotlin parser and syntax tree implementation with Tree-sitter integration (~2,000+ lines)
Symbol indexing system (classpath, stdlib, project, file, package, extension indexes)
Semantic analysis engine with complete type inference, diagnostics, and symbol resolution
LSP server implementation (initialization, request/response handlers, document/workspace services)
Language feature providers (completion, hover, definition, references, code actions, diagnostics, semantic tokens, document symbols)
Symbol model with full visitor pattern implementation for AST traversal
Analysis scheduling and document state management with caching
Diagnostic collection and reporting infrastructure

Build Configuration:

Removed api(projects.lsp.kotlinCore) dependency from lsp/jvm-symbol-index/build.gradle.kts
Deleted entire lsp/kotlin-core/build.gradle.kts module definition

Scope of Changes

Files Deleted: 40+ source files
Lines Removed: ~6,500+ lines across Kotlin parser, symbol model, semantic analysis, and LSP server implementations
Affected Modules: lsp/kotlin-core (complete removal), lsp/jvm-symbol-index (dependency adjustment)

⚠️ Breaking Changes & Risks

Functionality Removed:

Kotlin language server features completely unavailable
IDE features for Kotlin files eliminated: completeness proposals, hover information, go-to-definition, find references, diagnostics, symbol navigation
Any client code depending on Kotlin LSP will no longer function

Best Practice Violations:

No deprecation period or transition warning provided for end users
No documented migration guidance or alternative solutions referenced
Large single PR removing substantial functionality with minimal context (external Jira ticket ADFA-3721 not described)
Deleted code includes no backwards-compatibility shims or feature flags

Audit Trail Concerns:

Massive deletion of code in single commit makes rollback and historical analysis more difficult
Loss of substantial codebase without preserved rationale in commit messages

Downstream Impact Considerations

Projects relying on Kotlin language features in CodeOnTheGo will require alternative LSP implementations
Kotlin file editing will lose IDE intelligence previously provided by this module
No clear path forward for projects that need Kotlin support

Files Affected

Core deletions include:

lsp/kotlin-core/ (entire module)
lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/ (parser, index, semantic, server, symbol, provider implementations)
lsp/kotlin-core/build.gradle.kts
lsp/jvm-symbol-index/build.gradle.kts (dependency reference)

Walkthrough

This PR removes the entire Kotlin Language Server Protocol (LSP) implementation module (lsp/kotlin-core) and an API dependency declaration from lsp/jvm-symbol-index. The deletion eliminates parsing, symbol indexing, semantic analysis, and LSP server functionality for Kotlin support.

Changes

Cohort / File(s)	Summary
Build Configuration `lsp/kotlin-core/build.gradle.kts`, `lsp/jvm-symbol-index/build.gradle.kts`	Removed entire Kotlin core module build script and API dependency on `projects.lsp.kotlinCore` from jvm-symbol-index.
Parser Infrastructure `lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/parser/*`	Removed all parser-related classes: `KotlinParser`, `ParseResult`, `Position`, `PositionConverter`, `SyntaxKind`, `SyntaxNode`, `SyntaxTree`, `SyntaxVisitor`, `TextRange`; eliminates Tree-sitter based Kotlin parsing and syntax tree traversal.
Symbol Index Implementations `lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/index/*`	Deleted indexing classes: `ClasspathIndex`, `ClasspathIndexer`, `ExtensionIndex`, `FileIndex`, `PackageIndex`, `ProjectIndex`, `StdlibIndex`, `StdlibIndexLoader`, plus index data models (`IndexEntry.kt`) and the core `SymbolIndex` interface; removes symbol lookup across classpath, stdlib, and project sources.
Semantic Analysis `lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/semantic/*`	Removed semantic analyzer infrastructure: `AnalysisContext`, `Diagnostic` (enum/classes/collector), `OverloadResolver`, `SemanticAnalyzer`, `SymbolResolver`, `TypeInferrer`; eliminates type checking, symbol resolution, and error/warning diagnostics generation.
Symbol Model `lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/symbol/*`	Deleted symbol representation classes: `Symbol` (sealed base + subclasses), `Modifiers`, `Scope`, `ScopeKind`, `SymbolBuilder`, `SymbolLocation`, `SymbolTable`, `SymbolVisitor`, `Visibility`; removes in-memory symbol hierarchy and scope-based name resolution.
LSP Server Implementation `lsp/kotlin-core/src/main/java/org/appdevforall/codeonthego/lsp/kotlin/server/*`	Removed server infrastructure: `KotlinLanguageServer`, `KotlinTextDocumentService`, `KotlinWorkspaceService`, `AnalysisCache`, `AnalysisScheduler`, `DocumentManager`, `DocumentState`, plus all feature providers (`CodeActionProvider`, `CompletionProvider`, `DefinitionProvider`, `DiagnosticProvider`, `DocumentSymbolProvider`, `HoverProvider`, `SemanticTokenProvider`); eliminates LSP4J integration and all language server request handlers.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

ADFA-2417: Add LSP support for Kotlin #907 — Directly introduced the lsp/kotlin-core module and its public API surface (symbol indexes, parser, semantic analysis), which is now being removed by this PR; reverses the addition of the same classes and files.
ADFA-2956: Improve kotlin Library Indexing: Member-Level Completions from Dependencies #983 — Made targeted feature enhancements to the symbol index, parser, completion, and semantic analysis infrastructure that this PR deletes entirely; shares direct overlap on modified classes like ClasspathIndex, SymbolBuilder, CompletionProvider, and AnalysisContext.

Suggested reviewers

Daniel-ADFA
dara-abijo-adfa

Poem

🐰 Hop away, dear Kotlin dreams,
Through parser trees and symbol streams,
A brave retreat, so bold and clean—
The LSP module's no more seen! 🌙

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/ADFA-3721-remove-unused-modules

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa added 30 commits March 19, 2026 22:07

fix: add ability to re-write class name references in desugar plugin

1b069cb

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: integrate Kotlin analysis API

a70fd66

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Merge branch 'stage' into fix/ADFA-3366-include-analysis-api-as-depen…

4ca1e97

…dency

fix: update kotlin-android to latest version

43286a6

fixes duplicate class errors for org.antrl.v4.* classes Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: remove UnsafeImpl

f1fe62f

It is now included in the embeddable JAR (named UnsafeAndroid) with proper relocations. Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: update kotlin-android to latest version

6e6d8b3

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: replace usages of Unsafe with UnsafeImpl

b208658

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: make Kotlin LSP no-op

c844ad2

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: configure K2 standalone session when setting up LSP

58db2cb

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: JvmTarget resolution fails for input "21"

bf7acd1

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: do not early-init VirtualFileSystem

dc62a51

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: remove replaceClass desugar instruction for Unsafe

4b1c8e4

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: ensure boot class path is added as dependency to Android modules

b14f6ee

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add diagnostic provider for Kotlin

54ca7a9

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: remove unnecessary log statement

6e4d458

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: update to latest kotlin-android release

5d841a3

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: always re-initialize K2 session on setupWithProject

4b7b0f2

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: diagnostics are always collected from the on-disk file

e2f137a

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add the ability to incrementally invalidate source roots on pro…

09fc9ea

…ject re-sync Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: dispatch build-related events from GradleBuildService

dd3d519

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: introduct KtFileManager

d6defa6

Handles document events to manage instances of in-memory KtFile that can be used by various Kt LSP components (like diagnostics provider, code completions) to re-use already parsed KtFile instances Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: add initial K2-backed scope code completions

4666893

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add member completions backed by K2

2f982a7

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: suggest local and imported extension functions

4129a47

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: do not suggest extension functions for scope completions

7d736fa

This ensures that extension functions whose receiver type is not available in the current scope are not suggested for scope completions Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add scope-sensitive keyword completions

87234f8

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add indexing api and service implementation

7d78db1

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: metadata version is sometimes not parsed

c35aa9f

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: make JvmSymbolIndex exclusive to external libraries

bede4db

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add module resolver to resolve library modules from source path

9eb4ffe

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa added 12 commits April 10, 2026 18:21

fix: infinite loop when converting type names to display names

ab5c7d9

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: update ModuleResolver to resolve KaSourceModule from file path

0ec7b4b

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: update KotlinSourceScanner to use internal names in index

bf9b2da

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add custom implementations of analysis API services

49e7efe

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add support for indexing classes using VirtualFile

51d0686

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: create in-memory KtFile instances for modified files

e77df48

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: IndexWorker always re-index libraries

340b08b

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add KtFile.backingFilePath for better resolution of declaring m…

a1d999e

…odules Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: remove library indexing logic for kt index worker

49542ad

Libraries are already indexed by JvmLibraryIndexingService Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

feat: add index for generated JARs

888193f

This indexed is *always* refreshed after every successful build Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

fix: java source files are not recognized by analysis API

f3997a5

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa requested a review from a team April 15, 2026 06:37

itsaky-adfa self-assigned this Apr 15, 2026

itsaky-adfa changed the title ~~fix: remove unused kotlin lsp modules~~ ADFA-3721: remove unused kotlin lsp modules Apr 15, 2026

fix: remove unused kotlin lsp modules

a0e3075

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa force-pushed the fix/ADFA-3721-remove-unused-modules branch from 093148e to a0e3075 Compare April 15, 2026 06:38

Daniel-ADFA approved these changes Apr 15, 2026

View reviewed changes

itsaky-adfa added 6 commits April 16, 2026 00:54

chore: trigger ci

bcbbba3

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Merge branch 'stage' into feat/ADFA-3320-non-imported-ext-func-comple…

d109866

…tions

Merge branch 'feat/ADFA-3320-non-imported-ext-func-completions' into …

083388b

…feat/ADFA-3581-source-index

Merge branch 'stage' into feat/ADFA-3581-source-index

26406cc

fix: remove unused duplicate file

81f403d

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

Merge branch 'feat/ADFA-3581-source-index' into fix/ADFA-3721-remove-…

14416c3

…unused-modules

Base automatically changed from feat/ADFA-3581-source-index to stage April 20, 2026 20:58

Merge branch 'stage' into fix/ADFA-3721-remove-unused-modules

9e079cf

fix: remove reference to now-removed kotlinCore module

883f871

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>

itsaky-adfa merged commit 6517774 into stage Apr 20, 2026
2 checks passed

itsaky-adfa deleted the fix/ADFA-3721-remove-unused-modules branch April 20, 2026 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADFA-3721: remove unused kotlin lsp modules#1184

ADFA-3721: remove unused kotlin lsp modules#1184
itsaky-adfa merged 57 commits intostagefrom
fix/ADFA-3721-remove-unused-modules

itsaky-adfa commented Apr 15, 2026 •

edited by atlassian Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 20, 2026 •

edited

Loading

Release Notes: Removal of Kotlin LSP Modules (ADFA-3721)

Summary

Changes Removed

Scope of Changes

⚠️ Breaking Changes & Risks

Downstream Impact Considerations

Files Affected

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

itsaky-adfa commented Apr 15, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes: Removal of Kotlin LSP Modules (ADFA-3721)

Summary

Changes Removed

Scope of Changes

⚠️ Breaking Changes & Risks

Downstream Impact Considerations

Files Affected

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

itsaky-adfa commented Apr 15, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Apr 20, 2026 •

edited

Loading