ADFA-3640 | Fix fullscreen button overlapping by moving it to bottom start

[jatezzz]

Description

This PR resolves a UI/UX issue where the full-screen toggle button overlapped with icons inside the EditorBottomSheet (such as the trashcan). The button has been moved from the bottom-end to the bottom-start corner. The immersive mode inset calculations in WindowInsetsExtensions.kt were also updated to apply the proper startInset based on the system layout direction (LTR/RTL) instead of the endInset.

Details

Phone

Screen.Recording.2026-04-16.at.3.01.45.PM.mov

Tablet

document_5118862029054018935.mp4

Ticket

ADFA-3640

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a159d82e-1236-4413-ad33-1a7be0721b40

📥 Commits

Reviewing files that changed from the base of the PR and between 683b551 and 454ad1e.

📒 Files selected for processing (3)

• app/src/main/java/com/itsaky/androidide/utils/WindowInsetsExtensions.kt
• app/src/main/res/layout-land/content_editor.xml
• app/src/main/res/layout/content_editor.xml

---

📝 Walkthrough

Release Notes

• Fixed UI/UX Issue: Resolved overlapping fullscreen button that was obscuring icons in the EditorBottomSheet (e.g., trashcan icon)
• Button Repositioned: Moved the fullscreen toggle button from bottom-end to bottom-start corner
• Layout Updates:
  • Updated portrait layout (content_editor.xml): Changed button gravity from bottom|end to bottom|start and margin from marginEnd to marginStart
  • Updated landscape layout (content_editor.xml-land): Same gravity and margin adjustments for landscape orientation
• Immersive Mode Inset Handling: Refactored WindowInsetsExtensions.kt to apply correct horizontal inset based on system layout direction (LTR/RTL), switching from endInset to startInset calculation with corresponding marginStart application

Risks & Considerations

• RTL Language Support: Verify the inset calculation properly handles Right-to-Left (RTL) layouts, as the change inverts the inset mapping logic. Confirm visual alignment on RTL-enabled devices
• Multi-Device Testing Required: Visual references provided for phone and tablet - ensure regression testing covers both form factors and all supported screen sizes and orientations
• Layout Direction Assumptions: Confirm that switching from marginEnd/endInset to marginStart/startInset correctly respects system layout direction on all Android API levels supported by the app

Walkthrough

The pull request repositions the fullscreen toggle button in the content editor from end-aligned to start-aligned. The Kotlin code refactors horizontal inset computation from endInset to startInset with reversed mapping, and updates layout margin application accordingly. XML layout files are updated to reflect this positional change across both portrait and landscape orientations.

Changes

Cohort / File(s)	Summary
Immersive Mode Inset Handling app/src/main/java/com/itsaky/androidide/utils/WindowInsetsExtensions.kt	Refactored horizontal inset calculation in applyImmersiveModeInsets() from computing endInset to computing startInset with opposite RTL mapping; updated fullscreen toggle layout params to apply the inset to marginStart instead of marginEnd.
Content Editor Layout Files app/src/main/res/layout/content_editor.xml, app/src/main/res/layout-land/content_editor.xml	Updated fullscreen toggle button positioning from `bottom

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ADFA-2646 | Fix window insets accumulation and landscape appbar behavior #1114: Directly modifies the same ContentEditorBinding.applyImmersiveModeInsets() logic and fullscreen toggle positioning with RTL-aware horizontal inset adjustments.
• ADFA-3048 | Implement landscape immersive mode for editor #1101: Shares identical changes to immersive-mode inset computation and start/end margin swapping for the fullscreen toggle button.
• ADFA-3569 | Refactor editor fullscreen state handling #1149: Modifies the same immersive UI components—the inset application logic and fullscreen toggle layout positioning.

Suggested reviewers

• itsaky-adfa
• dara-abijo-adfa
• Daniel-ADFA

Poem

🐰 From right to left, the button hops,
Once at the end, now at the start,
RTL logic gently swaps,
Layout margins play their part,
Immersive views shine bright! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: moving the fullscreen button to bottom start to fix overlapping issues, which aligns with the changeset modifications across Kotlin and layout XML files.
Description check	✅ Passed	The description is directly related to the changeset, explaining the UI/UX issue being resolved and detailing the button repositioning and inset calculation updates across multiple files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ADFA-3640-fullscreen-button-overlap

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}