ADFA-3587 Change logo from ADFA to CoGo on Preferences > About page

[hal-eisen-adfa]

Add the new CoGo branding SVG to drawables
Start using it for About page within Preferences

I went with the same image for both light mode and dark mode. The pure black-n-white images didn't look good.

[coderabbitai]

📝 Walkthrough

Changes

• Replaced ADFA logo with new CoGo brand mark SVG vector on the About page (Preferences > About)
• Added new cogo_brand_mark.xml vector drawable resource files in both light and dark theme directories
• Updated About page layout to display the 48×89dp CoGo brand mark instead of the previous 64×64dp icon
• Removed unnecessary view styling attributes (background and shape appearance) from the About page header

Risks & Best Practice Violations

Color Hardcoding in Vector Drawables: The SVG assets use hardcoded hex color values (#233490, #FFFFFF, #00BE00) instead of referencing Android color resources. While these colors exist in colors.xml (primary_blue, brand_color), they are not used in the vector XML files. This violates the Android best practice of centralizing color definitions and makes future theme adjustments more error-prone. Consider refactoring the vector drawables to use ?attr/ theme references or color resource bindings where possible.

Single Asset for Both Themes: The same SVG is used for both light and dark modes as noted by the submitter. While understandable if black-and-white variants appeared visually poor, consider validating that the blue (#233490), white, and green (#00BE00) color combination provides adequate contrast and visual appeal in both light and dark application themes.

Walkthrough

The changes introduce a new brand mark vector drawable with day and night theme variants, each 48dp × 89dp, featuring a phone design with navigation UI elements and globe icon. A layout file is updated to reference and display this new drawable instead of the previous launcher foreground icon.

Changes

Cohort / File(s)	Summary
Layout Updates app/src/main/res/layout/layout_about_header.xml	ShapeableImageView dimensions adjusted from 64dp×64dp to 48dp×89dp; background and shapeAppearance attributes removed; drawable reference changed from ic_launcher_foreground to cogo_brand_mark.
Brand Mark Drawables resources/src/main/res/drawable/cogo_brand_mark.xml, resources/src/main/res/drawable-night/cogo_brand_mark.xml	Two new vector drawable resources added (48dp × 89dp). Each depicts a phone silhouette with navigation controls, camera, home button, and globe graphic. Day variant uses standard colors; night variant uses dark theme palette.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Suggested reviewers

• itsaky-adfa
• dara-abijo-adfa
• Daniel-ADFA

Poem

🐰 A brand new mark hops into view,
With phone and globe in day and night so true,
Dimensions precise, the vector glows bright,
The rabbit approves—what a delightful sight! ✨📱

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: replacing the ADFA logo with CoGo branding on the About page in Preferences.
Description check	✅ Passed	The description is related to the changeset, explaining the addition of CoGo branding SVGs and their use on the About page, matching the files and changes present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-3587-In-ABOUT-page-change-brand-mark

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

resources/src/main/res/drawable-night/cogo_brand_mark.xml (1)

1-47: Night variant duplicates the day drawable — consider removing it.

This file is byte-for-byte identical to resources/src/main/res/drawable/cogo_brand_mark.xml (same hard-coded fills #233490, #FFFFFF, #00BE00). Since the brand mark intentionally uses the same colors in both themes (per the PR description), the drawable-night/ qualifier adds no value and just doubles the maintenance cost — any future tweak to the artwork has to be made in two places and will silently drift if one copy is missed.

Recommend deleting this file and keeping only resources/src/main/res/drawable/cogo_brand_mark.xml; the default drawable resolves in both light and dark modes automatically. If a distinct dark-mode variant is planned later, it can be reintroduced at that time.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@resources/src/main/res/drawable-night/cogo_brand_mark.xml` around lines 1 -
47, The night-theme drawable is an exact duplicate of the default brand vector
(the cogo_brand_mark.xml vector using fill colors `#233490`, `#FFFFFF` and `#00BE00`),
so remove the redundant night variant file and keep only the single default
drawable (the <vector> element with those fillColor values) so the same artwork
is resolved in both light and dark modes; if a true dark-specific variant is
needed later, reintroduce a drawable-night/cogo_brand_mark.xml at that time.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@resources/src/main/res/drawable-night/cogo_brand_mark.xml`:
- Around line 1-47: The night-theme drawable is an exact duplicate of the
default brand vector (the cogo_brand_mark.xml vector using fill colors `#233490`,
`#FFFFFF` and `#00BE00`), so remove the redundant night variant file and keep only
the single default drawable (the <vector> element with those fillColor values)
so the same artwork is resolved in both light and dark modes; if a true
dark-specific variant is needed later, reintroduce a
drawable-night/cogo_brand_mark.xml at that time.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d7110c0-c3dd-4f24-a933-b9adc11b9579

📥 Commits

Reviewing files that changed from the base of the PR and between b4b73dc and 285dd81.

📒 Files selected for processing (3)

• app/src/main/res/layout/layout_about_header.xml
• resources/src/main/res/drawable-night/cogo_brand_mark.xml
• resources/src/main/res/drawable/cogo_brand_mark.xml