ADFA-3553 Update logo on 1st onboarding slide

[hal-eisen-adfa]

Switch from globe to phone image

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9739874-95e7-4fe5-85c5-fff63b20b7e9

📥 Commits

Reviewing files that changed from the base of the PR and between fb067ea and 829c72e.

📒 Files selected for processing (3)

• app/src/main/res/layout-land/fragment_onboarding_greeting.xml
• app/src/main/res/layout-sw600dp/fragment_onboarding_greeting.xml
• app/src/main/res/layout/fragment_onboarding_greeting.xml

---

📝 Walkthrough

Release Notes

• Updated onboarding greeting screen imagery across all device configurations (portrait, landscape, and tablet layouts) to use the new cogo_brand_mark drawable instead of previous logo variants

• Increased logo size to 150dp (portrait/landscape) and 200dp (tablet) to provide more visual prominence on the onboarding screen

• Risk: Layout sizing change - The default portrait layout changed the icon width from constraint-driven (0dp, stretching to available space) to wrap_content. This means the logo will no longer scale with screen width and may appear too small or misaligned on different screen sizes if the drawable's intrinsic dimensions aren't optimal

• Risk: Removed rounded corner styling - The app:shapeAppearance="@style/ShapeAppearance.Material3.Corner.Full" attribute was removed from landscape and tablet layouts. If the drawable doesn't include rounded corners, the logo will now appear with sharp edges, potentially creating a visual inconsistency with Material Design guidelines

• Old drawables remain in use - Previous logo drawables (app_dev_for_all_logo and ic_launcher_fg_vector) are still used in other screens (sidebar header and permissions info layouts) and should not be removed

Walkthrough

Updates the onboarding greeting layout drawable across three screen configurations (default, landscape, and tablet) from various sources to the new cogo_brand_mark, removes shape appearance styling, and adjusts layout constraints and sizing parameters.

Changes

Cohort / File(s)	Summary
Onboarding Greeting Layout Variants app/src/main/res/layout/fragment_onboarding_greeting.xml, app/src/main/res/layout-land/fragment_onboarding_greeting.xml, app/src/main/res/layout-sw600dp/fragment_onboarding_greeting.xml	Updated ShapeableImageView drawable resource to @drawable/cogo_brand_mark across all screen configurations (replacing app_dev_for_all_logo, ic_launcher_fg_vector), removed app:shapeAppearance="@style/ShapeAppearance.Material3.Corner.Full" attribute, and adjusted layout constraints and dimensions for default and landscape variants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• PR #1196: Both PRs update ShapeableImageView instances to use the new cogo_brand_mark drawable and remove the Material3 corner shape appearance styling.
• PR #1197: Related branding update that replaces launcher and splash drawable assets alongside this onboarding UI asset swap.

Suggested reviewers

• jomen-adfa
• Daniel-ADFA

Poem

🐰 Hops through layouts, left and right,
Brand new mark shines fresh and bright,
Constraints adjusted, shapes removed with care,
Onboarding greeting now shows flair! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Update logo on 1st onboarding slide' directly matches the changeset which updates the logo/drawable resource across all onboarding greeting layout variations.
Description check	✅ Passed	The description 'Switch from globe to phone image' relates to the changeset by referencing the visual change from one drawable to another on the onboarding slide.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-3553-IP-rebranding-in-splash-screen

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}