Skip to content

ADFA-3571 Change logo on home page and onboarding permissions info page#1209

Merged
hal-eisen-adfa merged 2 commits intostagefrom
ADFA-3571-Add-Code-On-the-Go-logo-throughout-product
Apr 18, 2026
Merged

ADFA-3571 Change logo on home page and onboarding permissions info page#1209
hal-eisen-adfa merged 2 commits intostagefrom
ADFA-3571-Add-Code-On-the-Go-logo-throughout-product

Conversation

@hal-eisen-adfa
Copy link
Copy Markdown
Collaborator

I still need to remove some obsolete images of the old logo

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1c493096-e115-4d0a-81e1-636adb2320c2

📥 Commits

Reviewing files that changed from the base of the PR and between 43684b2 and 1ba5149.

📒 Files selected for processing (3)
  • app/src/main/res/layout-land/fragment_main.xml
  • app/src/main/res/layout/fragment_main.xml
  • app/src/main/res/layout/fragment_permissions_info.xml

📝 Walkthrough

Release Notes

Changes

  • Updated logo references on the home page (fragment_main.xml in both standard and landscape layouts) from @drawable/ic_launcher_main to @drawable/cogo_brand_mark
  • Updated logo reference on the onboarding permissions info page (fragment_permissions_info.xml) from @drawable/app_dev_for_all_logo to @drawable/cogo_brand_mark

New Assets

  • Added cogo_brand_mark vector drawable with light and dark (night) theme variants in the resources module

Risks & Best Practices Violations

  • Cross-module drawable references: The app module references drawables defined in the resources module. While the dependency exists, ensure the build system correctly merges resources from both modules at compile time
  • Obsolete image cleanup incomplete: The original logo images (ic_launcher_main and app_dev_for_all_logo) remain in the codebase despite being replaced. These should be removed to reduce APK size and avoid confusion. This is noted as remaining work in the PR description
  • Partial migration: Other screens already reference cogo_brand_mark (fragment_onboarding_greeting.xml, layout_about_header.xml, layout_editor_sidebar_header.xml), suggesting this is part of a larger branding migration. Ensure consistency across all branding updates

Testing Recommendations

  • Verify dark mode rendering of the new logo across all affected screens
  • Confirm layout appearance in both portrait and landscape orientations
  • Validate that the drawable resources load correctly from the resources module dependency

Walkthrough

Three layout files are updated to consistently use a new brand mark drawable (@drawable/cogo_brand_mark) in place of previous drawable resources across different screen orientations and UI screens.

Changes

Cohort / File(s) Summary
Drawable Asset Updates in Layouts
app/src/main/res/layout-land/fragment_main.xml, app/src/main/res/layout/fragment_main.xml, app/src/main/res/layout/fragment_permissions_info.xml
Updated ShapeableImageView drawable sources to reference @drawable/cogo_brand_mark instead of previous launcher and logo drawables

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #1196: Updates layout image references to use @drawable/cogo_brand_mark and introduces the new drawable resource.
  • PR #1203: Performs consistent branding changes by replacing ShapeableImageView drawable sources with @drawable/cogo_brand_mark.
  • PR #842: Modifies fragment_permissions_info.xml layout and impacts the logo view component.

Suggested reviewers

  • jomen-adfa
  • jatezzz
  • itsaky-adfa

Poem

🐰 Hops of joy, the brand takes flight,
New marks shine oh-so-bright!
Three layouts dance in harmony,
Cogo's mark for all to see!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: replacing logos on the home page and permissions info page with the new brand mark.
Description check ✅ Passed The description is related to the changeset, acknowledging the logo updates and noting remaining cleanup work for obsolete images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ADFA-3571-Add-Code-On-the-Go-logo-throughout-product

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hal-eisen-adfa hal-eisen-adfa merged commit 9af9102 into stage Apr 18, 2026
2 checks passed
@hal-eisen-adfa hal-eisen-adfa deleted the ADFA-3571-Add-Code-On-the-Go-logo-throughout-product branch April 18, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants