ADFA-3608: Add Discover plugins shortcut to Plugin Manager toolbar

[Daniel-ADFA]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fc1231c3-e335-49ad-ab76-13f8d7368824

📥 Commits

Reviewing files that changed from the base of the PR and between 173d7f2 and b453b13.

📒 Files selected for processing (5)

• app/src/main/java/com/itsaky/androidide/activities/PluginManagerActivity.kt
• app/src/main/java/com/itsaky/androidide/preferences/rootPrefExts.kt
• app/src/main/res/menu/menu_plugin_manager.xml
• resources/src/main/res/drawable/ic_download.xml
• resources/src/main/res/values/strings.xml

---

📝 Walkthrough

Release Notes - ADFA-3608: Add Discover plugins shortcut to Plugin Manager toolbar

Features

• New "Discover plugins" toolbar button: Added a dedicated action menu item in the Plugin Manager activity that allows users to quickly access the plugins discovery page
• Plugin Manager always accessible: Plugin Manager entry is now always available in preferences (no longer behind experimental feature flag)
• External link integration: Users can now directly navigate to the plugin contribution/discovery page via the new toolbar shortcut

Changes

• Updated PluginManagerActivity with menu options handling:
  • Added onCreateOptionsMenu() to inflate the new plugin manager menu
  • Added onOptionsItemSelected() to handle the "Discover plugins" action
  • Long-press tooltip support for the new button
• Added new menu resource menu_plugin_manager.xml with the discover plugins action item
• Added new download vector icon (ic_download.xml)
• Added string resources: action_discover_plugins and url_discover_plugins

⚠️ Risks & Concerns

1. Hardcoded external URL: The plugin discovery URL is hardcoded in strings.xml. While good for localization support, consider whether this URL should be dynamically configurable or managed through a configuration service for easier updates in future releases.
2. Feature flag removal: The Plugin Manager entry was previously gated behind FeatureFlags.isExperimentsEnabled. Removing this gate makes the feature always visible. Verify that this intentional behavioral change is documented and all dependent systems are ready for this.
3. No end-of-file newline: The ic_download.xml vector drawable file lacks a trailing newline, which is inconsistent with many code style guidelines.

Walkthrough

Added an options menu to PluginManagerActivity with a "Discover plugins" menu item that opens an external URL. Removed the experimental feature flag condition for the Plugin Manager entry in preferences, making it always available. Added supporting resources including a download icon, menu XML definition, and string resources.

Changes

Cohort / File(s)	Summary
Plugin Manager Activity app/src/main/java/com/itsaky/androidide/activities/PluginManagerActivity.kt, app/src/main/res/menu/menu_plugin_manager.xml	Implemented onCreateOptionsMenu to inflate the plugin manager menu and attach a long-press tooltip listener, and onOptionsItemSelected to handle discover-plugins action by opening a URL via UrlManager.
Resource Assets resources/src/main/res/drawable/ic_download.xml, resources/src/main/res/values/strings.xml	Added vector drawable for download icon and new string resources for the discover plugins action label and external contribution URL.
Preferences Configuration app/src/main/java/com/itsaky/androidide/preferences/rootPrefExts.kt	Removed conditional logic that gated PluginManagerEntry() behind FeatureFlags.isExperimentsEnabled, now always adds the entry unconditionally.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• ADFA-2714 Add tooltip for Plugin Manager #1007: Introduced the TooltipTag.PLUGIN_MANAGER tooltip tag and long-press tooltip support infrastructure that this PR leverages in the onCreateOptionsMenu handler.
• ADFA-3270: Add erase installation file when done button to Plugin Manager #1119: Also modifies PluginManagerActivity with file-picker, install, and delete behavior, creating overlapping touchpoints with this PR's menu handling additions.

Suggested reviewers

• jomen-adfa
• jatezzz
• dara-abijo-adfa

Poem

🐰 A download icon hops into view,
Menu options shiny, fresh, and new,
Discover plugins with a single tap,
No more feature flags to close the gap,
The plugin manager's ready to go! 🚀

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to evaluate whether it relates to the changeset.	Add a brief description explaining the purpose and implementation of the Plugin Manager discover plugins feature.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a discover plugins shortcut to the Plugin Manager toolbar, matching the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ADFA-3608

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}