ADFA-3615 | Group radio buttons together in XML generation#1219
Merged
ADFA-3615 | Group radio buttons together in XML generation#1219
Conversation
Contributor
📝 WalkthroughRelease Notes - ADFA-3615: Radio Button Grouping in XML GenerationFeatures & Improvements
Architecture Changes
|
| Cohort / File(s) | Summary |
|---|---|
Layout model & processing cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/model/LayoutItem.kt, cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/LayoutGeometryProcessor.kt |
Added sealed LayoutItem types (SimpleView, HorizontalRow, RadioGroup) and buildLayoutTree() which groups/scans boxes into rows and merges radio button labels, producing layout items. |
Widget abstraction cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidWidget.kt |
Introduced AndroidWidget sealed hierarchy and concrete widget classes to map box labels + parsed attributes to Android view tags and per-widget attributes/id resolution. |
Rendering pipeline cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt |
New LayoutRenderer that walks LayoutItem trees and emits Android XML for simple views, horizontal rows (computing margins), and radio groups (id allocation, checked handling). |
XML output & IDs cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt |
Added XmlContext for building XML strings, deterministic per-label id generation/registration (nextId, resolveId), and String.escapeXmlAttr() attribute escaping. |
Generator & integration cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidXmlGenerator.kt, cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/YoloToXmlConverter.kt |
Added new AndroidXmlGenerator that orchestrates prolog, optional ScrollView, layout-tree creation and rendering; updated YoloToXmlConverter to take an AndroidXmlGenerator and delegate XML generation. |
Removed legacy cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/AndroidXmlGenerator.kt |
Deleted previous monolithic AndroidXmlGenerator implementation (all XML construction helpers and procedural emission removed). |
Sequence Diagram(s)
sequenceDiagram
participant Client
participant Yolo as YoloToXmlConverter
participant Gen as AndroidXmlGenerator
participant Geo as LayoutGeometryProcessor
participant Renderer as LayoutRenderer
participant Context as XmlContext
Client->>Yolo: generateXmlLayout(detections, annotations, ...)
Yolo->>Gen: buildXml(boxes, annotations, targetDpHeight, wrapInScroll)
Gen->>Geo: buildLayoutTree(boxes)
Geo-->>Gen: List<LayoutItem>
Gen->>Renderer: render(item) [for each LayoutItem]
Renderer->>Context: append elements, register ids
Renderer-->>Gen: rendered fragments
Gen->>Context: finalize wrapper tags
Gen-->>Yolo: xml String
Yolo-->>Client: xml String
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~40 minutes
Possibly related PRs
- ADFA-3617 | Support horizontal widgets in XML generation #1204: Refactors XML generation into modular generator/renderer/layout components—strong overlap with this change.
- ADFA-3709 | Refactor OCR fuzzy parsing and modularize YOLO to XML conversion #1185: Modifies YOLO→XML conversion and attribute handling, related to
YoloToXmlConverterand attribute parsing here. - ADFA-3107: Utilize YOLO detected tags in XML generation - Experimental #1028: Also changes XML-generation responsibilities and annotation propagation; closely related to widget/attribute changes.
Suggested reviewers
- Daniel-ADFA
- itsaky-adfa
- hal-eisen-adfa
Poem
🐇 I munched a layout into little parts,
Rows and radios, ids to chart,
Widgets spring from boxes neat,
XML hums a steady beat,
Hopping code that makes UIs smart.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and specifically describes the main change: grouping radio buttons into RadioGroup components in XML generation, which directly aligns with the core objective of this PR. |
| Description check | ✅ Passed | The description is directly related to the changeset, providing context about the radio button grouping feature, the new LayoutItem interface, geometry processing changes, and AndroidXmlGenerator updates for RadioGroup generation. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
feat/ADFA-3615-radio-button-grouping-experimental
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt (1)
24-29:escapeXmlAttr()silently trims — surprising side effect for a function named “escape”.This extension is applied to every attribute value emitted by
AndroidWidget.render(includingandroid:text,android:hint,android:contentDescription). An escape helper should only perform the replacements; trimming changes semantics (legitimate leading/trailing whitespace in user annotations becomes unrecoverable) and is easy to miss when this is called on values the caller assumes are already normalized.Recommend separating the concerns — callers that want to trim should trim explicitly before escaping.
♻️ Proposed change
-fun String.escapeXmlAttr(): String = this.trim() - .replace("&", "&") +fun String.escapeXmlAttr(): String = this + .replace("&", "&") .replace("<", "<") .replace(">", ">") .replace("\"", """) .replace("'", "'")🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt` around lines 24 - 29, The String.escapeXmlAttr() function silently trims input which changes semantics; remove the .trim() call so escapeXmlAttr only performs XML-escaping and does not alter leading/trailing whitespace, and update callers (e.g., AndroidWidget.render usage sites that pass values for android:text, android:hint, android:contentDescription) to explicitly call .trim() where trimming is desired before calling escapeXmlAttr; ensure tests (if any) reflect the new behavior.cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt (1)
61-75: Prefer a named type over an anonymousobject {}for per-radio state.The anonymous object expression works but is unidiomatic Kotlin — the properties are only usable within this local scope and tools/readers lose a type name for them. A small local
data class(or even aTriple/Pairof records) would be clearer and would make follow-on changes (e.g. the fix for the multi-checked issue above) easier.♻️ Proposed refactor
+ private data class RadioEntry( + val box: ScaledBox, + val attrs: Map<String, String>, + val id: String, + val extra: Map<String, String>, + val checked: Boolean + ) + private fun renderRadioGroup(boxes: List<ScaledBox>, orientation: String, indent: String) { ... - object { val box = box; val attrs = parsedAttrs; val id = id; val extra = extraAttrs; val checked = isChecked } + RadioEntry(box, parsedAttrs, id, extraAttrs, isChecked)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt` around lines 61 - 75, The local radios list is built using an anonymous object expression (object { val box = box; val attrs = parsedAttrs; ... }) which is unidiomatic and hides the type; replace that anonymous object with a small local named data class (e.g., RadioState with properties box, attrs, id, extra, checked) defined in LayoutRenderer.kt near the radios construction, then construct instances of RadioState in the mapIndexed lambda (use FuzzyAttributeParser.parse and context.nextId as before) so downstream code like radios.firstOrNull { it.checked }?.id can use a clear, named type.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidWidget.kt`:
- Line 20: The render logic currently uses idOverride or
parsedAttrs["android:id"] directly and only calls context.nextId(box.label) when
absent, which allows user-supplied ids to bypass the id counter and cause
collisions; change render() so that whenever you derive an id from idOverride or
parsedAttrs["android:id"] you also reserve/register it with the XmlContext
counter (e.g. call a method like XmlContext.reserveId(id) or add to
context.counters/usedIds) before returning, and if reservation detects an
existing reservation handle it (e.g. pick a unique fallback via context.nextId
or normalize) so context.nextId(box.label) will never later generate the same
id; update handling for both idOverride and parsedAttrs extraction code paths
(symbols: idOverride, parsedAttrs["android:id"], context.nextId(box.label),
XmlContext.reserveId / context.counters / usedIds).
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt`:
- Around line 58-98: renderRadioGroup can emit multiple children with
android:checked="true" causing contradictory XML; when calling renderSimpleView
for each radio, ensure non-selected radios are forced to have
"android:checked"="false" by adding that key to the parsedAttrsOverride map for
radios whose id != checkedId (leave the selected radio's parsedAttrs unchanged);
reference renderRadioGroup, the radios local objects, renderSimpleView call, and
TextBasedWidget.specificAttributes/parsedAttrsOverride so the change is made
where parsedAttrsOverride is passed through.
---
Nitpick comments:
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt`:
- Around line 61-75: The local radios list is built using an anonymous object
expression (object { val box = box; val attrs = parsedAttrs; ... }) which is
unidiomatic and hides the type; replace that anonymous object with a small local
named data class (e.g., RadioState with properties box, attrs, id, extra,
checked) defined in LayoutRenderer.kt near the radios construction, then
construct instances of RadioState in the mapIndexed lambda (use
FuzzyAttributeParser.parse and context.nextId as before) so downstream code like
radios.firstOrNull { it.checked }?.id can use a clear, named type.
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt`:
- Around line 24-29: The String.escapeXmlAttr() function silently trims input
which changes semantics; remove the .trim() call so escapeXmlAttr only performs
XML-escaping and does not alter leading/trailing whitespace, and update callers
(e.g., AndroidWidget.render usage sites that pass values for android:text,
android:hint, android:contentDescription) to explicitly call .trim() where
trimming is desired before calling escapeXmlAttr; ensure tests (if any) reflect
the new behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 35c4e640-aa9f-46af-9a66-7ab1d799d947
📒 Files selected for processing (8)
cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/AndroidXmlGenerator.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/LayoutGeometryProcessor.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/YoloToXmlConverter.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/model/LayoutItem.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidWidget.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidXmlGenerator.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt
💤 Files with no reviewable changes (1)
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/AndroidXmlGenerator.kt
avestaadfa
reviewed
Apr 20, 2026
jatezzz
force-pushed
the
feat/ADFA-3615-radio-button-grouping-experimental
branch
from
d369f50 to
55df292
Compare
Daniel-ADFA
reviewed
Apr 21, 2026
jatezzz
force-pushed
the
feat/ADFA-3615-radio-button-grouping-experimental
branch
from
6c2b43d to
7601466
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidWidget.kt (1)
20-25:⚠️ Potential issue | 🟡 MinorKeep parsed IDs collision-safe when registering them.
registerId()only records the ID; it does not reject or rewrite duplicates. If a parsedandroid:idequals an earlier generated/manual ID, this still emits duplicate@+id/...values. SplitidOverridefrom parsed IDs and make parsed-ID registration detect duplicates or fall back tonextId(...).🛡️ Sketch of the safer flow
- val manualId = idOverride ?: parsedAttrs["android:id"]?.substringAfterLast('/') - val id = if (manualId != null) { - context.registerId(manualId) - manualId - } else { - context.nextId(box.label) - } + val parsedId = parsedAttrs["android:id"]?.substringAfterLast('/') + val id = when { + idOverride != null -> idOverride + parsedId != null -> context.registerIdOrNull(parsedId) ?: context.nextId(box.label) + else -> context.nextId(box.label) + }Supporting
XmlContextchange:- fun registerId(id: String) { - usedIds.add(id) - } + fun registerIdOrNull(id: String): String? = + id.takeIf { usedIds.add(it) }
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/LayoutGeometryProcessor.kt`:
- Around line 136-149: Rows containing a radio circle plus adjacent label (e.g.,
[radio_button_unchecked, text]) are currently treated as generic HorizontalRow
because the branch only checks row.all { isRadioButton(it) }; update the logic
in LayoutGeometryProcessor to detect "radio option rows" before falling back to
HorizontalRow by recognizing rows with exactly one radio element and one
neighboring text/label element, attach/merge the label into the radio item's
model (use isRadioButton and the verticalRadioRun handling), then emit
LayoutItem.RadioGroup (horizontal or vertical using the existing
verticalRadioRun/flushVerticalRadioRun flow) instead of
LayoutItem.HorizontalRow; adjust the branches around rows.forEach to check for
single-radio+label patterns and handle them accordingly while preserving
existing vertical radio run logic.
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt`:
- Around line 61-75: When building radios, don't always call
context.nextId(box.label) first; instead check parsedAttrs for "android:id" and
resolve that into a collision-safe id using the same resolution logic
AndroidWidget uses (i.e. pass the parsed id through the same
context/id-normalization/collision-safe path), assign that resolved id to the
radio object (replace usages of the raw context.nextId result) and use the same
resolved id when computing checkedId (android:checkedButton) and when passing
idOverride later; apply the same change to the similar block around the other
occurrence (lines ~95-101) so annotated android:id values are preserved and
collision-safe.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f14a6f82-e87a-4882-bf52-7aa0afb9274b
📒 Files selected for processing (8)
cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/AndroidXmlGenerator.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/LayoutGeometryProcessor.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/YoloToXmlConverter.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/model/LayoutItem.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidWidget.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidXmlGenerator.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt
💤 Files with no reviewable changes (1)
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/AndroidXmlGenerator.kt
✅ Files skipped from review due to trivial changes (1)
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/model/LayoutItem.kt
🚧 Files skipped from review as they are similar to previous changes (2)
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidXmlGenerator.kt
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt
jatezzz
force-pushed
the
feat/ADFA-3615-radio-button-grouping-experimental
branch
from
7601466 to
f1986eb
Compare
Daniel-ADFA
approved these changes
Apr 21, 2026
Updated layout geometry processor to build a layout tree that detects contiguous radio buttons and generates corresponding `<RadioGroup>` XML tags.
…on and added safe guard for radios checked
…atch the spreadsheet
…e radio labels for proper RadioGroup parsing
jatezzz
force-pushed
the
feat/ADFA-3615-radio-button-grouping-experimental
branch
from
f1986eb to
0b28785
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt (1)
61-76: Replace the anonymousobject { ... }with a local data class for readability.The
object { val box = box; val attrs = parsedAttrs; ... }pattern relies on Kotlin anonymous-object type inference inside a private function. It works, but a named local data class is clearer, produces properequals/hashCode, avoids shadowing identifiers viaval box = box, and makes the radio record easier to refactor/extend later.♻️ Suggested refactor
- private fun renderRadioGroup(boxes: List<ScaledBox>, orientation: String, indent: String) { + private data class RadioChild( + val box: ScaledBox, + val attrs: Map<String, String>, + val id: String, + val extra: Map<String, String>, + val checked: Boolean, + ) + + private fun renderRadioGroup(boxes: List<ScaledBox>, orientation: String, indent: String) { val groupId = context.nextId("radio_group") val radios = boxes.mapIndexed { index, box -> val parsedAttrs = FuzzyAttributeParser.parse(annotations[box], "RadioButton") val requestedId = parsedAttrs["android:id"]?.substringAfterLast('/') val id = context.resolveId(requestedId, box.label) val extraAttrs = if (orientation == "horizontal" && index < boxes.lastIndex) { val gap = maxOf(0, boxes[index + 1].x - (box.x + box.w)) mapOf("android:layout_marginEnd" to "${gap}dp") } else emptyMap() val isChecked = box.label == "radio_button_checked" || parsedAttrs["android:checked"]?.equals("true", ignoreCase = true) == true - object { val box = box; val attrs = parsedAttrs; val id = id; val extra = extraAttrs; val checked = isChecked } + RadioChild(box, parsedAttrs, id, extraAttrs, isChecked) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt` around lines 61 - 76, Replace the anonymous object creation inside the radios mapIndexed with a small local data class (e.g., data class RadioItem(val box: BoxType, val attrs: Map<String,String>, val id: Int?, val extra: Map<String,String>, val checked: Boolean)) declared inside the same function in LayoutRenderer.kt; construct and return instances of that data class instead of object { ... } (use the existing parsedAttrs, id, extraAttrs and isChecked variables), which removes the val box = box shadowing and gives proper equals/hashCode, clearer code, and easier future refactors for the radios collection.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/LayoutGeometryProcessor.kt`:
- Around line 149-182: The buildLayoutTree currently emits a RadioGroup for a
single radio because verticalRadioRun is always converted to a RadioGroup;
change the logic so flushVerticalRadioRun() only creates LayoutItem.RadioGroup
when verticalRadioRun.size >= 2 and for a single entry it instead adds
LayoutItem.SimpleView(verticalRadioRun.first()), then clear the run; keep the
rest of buildLayoutTree and the places that add to verticalRadioRun (the branch
row.all { isRadioButton(it) } && row.size == 1) unchanged so accumulation still
works but lone radios are emitted as SimpleView rather than a 1-button
RadioGroup.
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidWidget.kt`:
- Around line 75-93: In specificAttributes(), avoid leaking internal box.label
into android:text when parsedAttrs["android:text"] is missing and box.text is
empty or equals box.label; instead, when tag is not in widgetTags set the
android:text to a neutral value (empty string or the tag name) or omit the
android:text entry entirely; update the logic around parsedAttrs, box.text,
box.label and tag in specificAttributes() so the fallback does not assign
box.label to attrs["android:text"] (keep tools:ignore if you still emit
android:text).
---
Nitpick comments:
In
`@cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.kt`:
- Around line 61-76: Replace the anonymous object creation inside the radios
mapIndexed with a small local data class (e.g., data class RadioItem(val box:
BoxType, val attrs: Map<String,String>, val id: Int?, val extra:
Map<String,String>, val checked: Boolean)) declared inside the same function in
LayoutRenderer.kt; construct and return instances of that data class instead of
object { ... } (use the existing parsedAttrs, id, extraAttrs and isChecked
variables), which removes the val box = box shadowing and gives proper
equals/hashCode, clearer code, and easier future refactors for the radios
collection.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0a43a52b-33b9-4c12-b01d-66f7155b6806
📒 Files selected for processing (8)
cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/AndroidXmlGenerator.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/LayoutGeometryProcessor.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/YoloToXmlConverter.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/model/LayoutItem.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidWidget.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidXmlGenerator.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/LayoutRenderer.ktcv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt
💤 Files with no reviewable changes (1)
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/AndroidXmlGenerator.kt
✅ Files skipped from review due to trivial changes (2)
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/model/LayoutItem.kt
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/AndroidXmlGenerator.kt
🚧 Files skipped from review as they are similar to previous changes (2)
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/YoloToXmlConverter.kt
- cv-image-to-xml/src/main/java/org/appdevforall/codeonthego/computervision/domain/xml/XmlContext.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added logic to group individual radio buttons detected by the Yolo model into standard Android
<RadioGroup>components. Introduced aLayoutItemsealed interface to construct a layout tree during geometry processing. TheLayoutGeometryProcessornow identifies sequences of adjacent radio buttons and clusters them horizontally or vertically. Finally,AndroidXmlGeneratortranslates these clusters into<RadioGroup>tags, automatically handling IDs, orientation, and thecheckedButtonattribute based on the parsed annotations.Details
document_5129774364132116179.mp4
Ticket
ADFA-3615