feat/ADFA-3381 removal of template legacy code#1270
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 Walkthrough
Risks / Best-practice violations (callouts):
WalkthroughThis PR removes the legacy template-builder subsystem (many templates, builders, helpers, and assets) and strips NDK installation from BaseAssetsInstaller, leaving only executable-permission setup for Android build-tool binaries. ChangesTemplate infrastructure and implementations (single cohort)
BaseAssetsInstaller: NDK removal (separate cohort)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
templates-api/src/main/java/com/itsaky/androidide/templates/base/ProjectTemplateBuilder.kt (1)
35-36: RemovedefModuleTemplate— unused dead code.The field at line 36 is declared as an immutable
valinitialized tonulland has no references in the codebase. The@PublishedApiannotation is also meaningless since it can never hold a meaningful value.Proposed removal
- `@PublishedApi` - internal val defModuleTemplate: ModuleTemplate? = null - `@PublishedApi`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates-api/src/main/java/com/itsaky/androidide/templates/base/ProjectTemplateBuilder.kt` around lines 35 - 36, Remove the dead immutable field defModuleTemplate and its `@PublishedApi` annotation from ProjectTemplateBuilder (the declaration "internal val defModuleTemplate: ModuleTemplate? = null"); delete the declaration and any now-unused imports or references related to `@PublishedApi/defModuleTemplate` and rebuild to ensure no compile errors or unused-import warnings remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@templates-api/src/main/java/com/itsaky/androidide/templates/base/ProjectTemplateBuilder.kt`:
- Around line 35-36: Remove the dead immutable field defModuleTemplate and its
`@PublishedApi` annotation from ProjectTemplateBuilder (the declaration "internal
val defModuleTemplate: ModuleTemplate? = null"); delete the declaration and any
now-unused imports or references related to `@PublishedApi/defModuleTemplate` and
rebuild to ensure no compile errors or unused-import warnings remain.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b46b9e64-5482-440a-b385-a3ba2a218d19
⛔ Files ignored due to path filters (8)
resources/src/main/res/drawable-xxxhdpi/template_blank_activity_drawer.pngis excluded by!**/*.pngresources/src/main/res/drawable-xxxhdpi/template_blank_activity_tabs.pngis excluded by!**/*.pngresources/src/main/res/drawable-xxxhdpi/template_bottom_navigation_activity.pngis excluded by!**/*.pngresources/src/main/res/drawable-xxxhdpi/template_compose_empty_activity.pngis excluded by!**/*.pngresources/src/main/res/drawable-xxxhdpi/template_empty_activity.pngis excluded by!**/*.pngresources/src/main/res/drawable-xxxhdpi/template_empty_noandroidx.pngis excluded by!**/*.pngresources/src/main/res/drawable-xxxhdpi/template_ndk_activity.pngis excluded by!**/*.pngresources/src/main/res/drawable-xxxhdpi/template_plugin.pngis excluded by!**/*.png
📒 Files selected for processing (99)
app/src/main/java/com/itsaky/androidide/assets/BaseAssetsInstaller.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/AndroidModuleTemplateBuilder.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/FileTemplateBuilder.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/ModuleTemplateBuilder.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/ProjectTemplateBuilder.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/androidx.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/base.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/modules/android/buildGradle.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/modules/android/manifest.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/modules/android/misc.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/modules/android/utils.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/modules/common.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/ndkExtensions.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/root/buildGradle.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/root/gradleWrapper.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/root/gradleWrapperSrc.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/root/settings.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/root/tomlSrc.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/util/AndroidManifestBuilder.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/util/AndroidModuleResManager.kttemplates-api/src/main/java/com/itsaky/androidide/templates/base/util/SourceWriter.kttemplates-impl/src/main/assets/templates/bottomNav/res/drawable/ic_dashboard_black_24dp.xmltemplates-impl/src/main/assets/templates/bottomNav/res/drawable/ic_home_black_24dp.xmltemplates-impl/src/main/assets/templates/bottomNav/res/drawable/ic_notifications_black_24dp.xmltemplates-impl/src/main/assets/templates/bottomNav/res/layout/activity_main.xmltemplates-impl/src/main/assets/templates/bottomNav/res/layout/fragment_dashboard.xmltemplates-impl/src/main/assets/templates/bottomNav/res/layout/fragment_home.xmltemplates-impl/src/main/assets/templates/bottomNav/res/layout/fragment_notifications.xmltemplates-impl/src/main/assets/templates/bottomNav/res/menu/bottom_nav_menu.xmltemplates-impl/src/main/assets/templates/bottomNav/res/values/dimens.xmltemplates-impl/src/main/assets/templates/navDrawer/res/drawable/ic_menu_camera.xmltemplates-impl/src/main/assets/templates/navDrawer/res/drawable/ic_menu_gallery.xmltemplates-impl/src/main/assets/templates/navDrawer/res/drawable/ic_menu_slideshow.xmltemplates-impl/src/main/assets/templates/navDrawer/res/drawable/side_nav_bar.xmltemplates-impl/src/main/assets/templates/navDrawer/res/layout/activity_main.xmltemplates-impl/src/main/assets/templates/navDrawer/res/layout/app_bar_main.xmltemplates-impl/src/main/assets/templates/navDrawer/res/layout/content_main.xmltemplates-impl/src/main/assets/templates/navDrawer/res/layout/fragment_gallery.xmltemplates-impl/src/main/assets/templates/navDrawer/res/layout/fragment_home.xmltemplates-impl/src/main/assets/templates/navDrawer/res/layout/fragment_slideshow.xmltemplates-impl/src/main/assets/templates/navDrawer/res/layout/nav_header_main.xmltemplates-impl/src/main/assets/templates/navDrawer/res/menu/activity_main_drawer.xmltemplates-impl/src/main/assets/templates/navDrawer/res/menu/main.xmltemplates-impl/src/main/assets/templates/navDrawer/res/values/dimens.xmltemplates-impl/src/main/assets/templates/tabbed/res/layout/activity_main.xmltemplates-impl/src/main/assets/templates/tabbed/res/layout/fragment_main.xmltemplates-impl/src/main/assets/templates/tabbed/res/values/dimens.xmltemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/base.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/layout.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/material.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/recipe.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/results.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/src.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/themes.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/basicActivity/basicActivityTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/basicActivity/src.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/bottomNavActivityTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcActivity.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcFragmentDashboard.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcFragmentHome.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcFragmentNotifications.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcViewModelDashboard.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcViewModelHome.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcViewModelNotifications.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcXml.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/composeActivity/composeActivityTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/composeActivity/srcActivity.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/composeActivity/srcTheme.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/composeActivity/srcThemesXml.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/emptyActivity/emptyActivityTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/emptyActivity/src.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/navDrawerActivityTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcActivity.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcFragments_gallery.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcFragments_home.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcFragments_slideshow.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcViewModel_gallery.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcViewModel_home.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcViewModel_slideshow.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcXml.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/ndkActivity/ndkActivityTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/ndkActivity/ndkSources.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/noActivity/noActivityTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/noAndroidXActivity/noAndroidXActivity.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/noAndroidXActivity/noAndroidXActivityTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/noAndroidXActivity/noAndroidXLayout.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/PluginTemplateData.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginBuildGradle.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginFragment.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginLayout.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginMainClass.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginManifest.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginProjectTemplate.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/srcActivity.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/srcPageViewModel.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/srcPagerAdapter.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/srcPlaceholderFragment.kttemplates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/tabbedActivityTemplate.kttemplates-impl/src/test/java/com/itsaky/androidide/templates/TemplateBuilderTest.kt
💤 Files with no reviewable changes (97)
- templates-impl/src/main/assets/templates/navDrawer/res/drawable/side_nav_bar.xml
- templates-impl/src/main/assets/templates/bottomNav/res/layout/fragment_home.xml
- templates-impl/src/main/assets/templates/navDrawer/res/drawable/ic_menu_gallery.xml
- templates-impl/src/main/assets/templates/navDrawer/res/drawable/ic_menu_slideshow.xml
- templates-impl/src/main/assets/templates/navDrawer/res/drawable/ic_menu_camera.xml
- templates-impl/src/main/assets/templates/bottomNav/res/drawable/ic_home_black_24dp.xml
- templates-impl/src/main/assets/templates/navDrawer/res/layout/fragment_slideshow.xml
- templates-impl/src/main/assets/templates/bottomNav/res/layout/fragment_notifications.xml
- templates-impl/src/main/assets/templates/navDrawer/res/layout/fragment_home.xml
- templates-impl/src/main/assets/templates/tabbed/res/layout/fragment_main.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/noAndroidXActivity/noAndroidXLayout.kt
- templates-impl/src/main/assets/templates/bottomNav/res/drawable/ic_notifications_black_24dp.xml
- templates-impl/src/main/assets/templates/navDrawer/res/layout/nav_header_main.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcViewModelNotifications.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcViewModel_home.kt
- templates-impl/src/main/assets/templates/bottomNav/res/drawable/ic_dashboard_black_24dp.xml
- templates-impl/src/main/assets/templates/navDrawer/res/layout/app_bar_main.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/recipe.kt
- templates-impl/src/main/assets/templates/navDrawer/res/menu/activity_main_drawer.xml
- templates-impl/src/main/assets/templates/navDrawer/res/values/dimens.xml
- templates-impl/src/main/assets/templates/tabbed/res/values/dimens.xml
- templates-impl/src/main/assets/templates/bottomNav/res/values/dimens.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/srcPageViewModel.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/FileTemplateBuilder.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginManifest.kt
- templates-impl/src/main/assets/templates/bottomNav/res/layout/fragment_dashboard.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginProjectTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcViewModel_slideshow.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/androidx.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/composeActivity/composeActivityTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/PluginTemplateData.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/modules/android/manifest.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/modules/android/utils.kt
- templates-impl/src/main/assets/templates/tabbed/res/layout/activity_main.xml
- templates-impl/src/main/assets/templates/navDrawer/res/layout/content_main.xml
- templates-api/src/main/java/com/itsaky/androidide/templates/base/root/tomlSrc.kt
- templates-impl/src/main/assets/templates/bottomNav/res/menu/bottom_nav_menu.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/navDrawerActivityTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcViewModel_gallery.kt
- templates-impl/src/main/assets/templates/navDrawer/res/layout/fragment_gallery.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/basicActivity/src.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcXml.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/emptyActivity/src.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/root/gradleWrapperSrc.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/util/SourceWriter.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/noActivity/noActivityTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginLayout.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/tabbedActivityTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/basicActivity/basicActivityTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginFragment.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcViewModelHome.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/layout.kt
- templates-impl/src/main/assets/templates/navDrawer/res/layout/activity_main.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/srcPlaceholderFragment.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/root/settings.kt
- templates-impl/src/main/assets/templates/navDrawer/res/menu/main.xml
- templates-api/src/main/java/com/itsaky/androidide/templates/base/root/gradleWrapper.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcXml.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcViewModelDashboard.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/modules/android/misc.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/ModuleTemplateBuilder.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcFragmentNotifications.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/srcActivity.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginBuildGradle.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/bottomNavActivityTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcFragmentHome.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcFragments_slideshow.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcFragments_home.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/tabbedActivity/srcPagerAdapter.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/root/buildGradle.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/src.kt
- templates-impl/src/test/java/com/itsaky/androidide/templates/TemplateBuilderTest.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/ndkActivity/ndkSources.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/modules/common.kt
- templates-impl/src/main/assets/templates/bottomNav/res/layout/activity_main.xml
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/composeActivity/srcTheme.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/base.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/util/AndroidManifestBuilder.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/composeActivity/srcActivity.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcFragmentDashboard.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/util/AndroidModuleResManager.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/noAndroidXActivity/noAndroidXActivity.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/material.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/ndkActivity/ndkActivityTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/composeActivity/srcThemesXml.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/emptyActivity/emptyActivityTemplate.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/ndkExtensions.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/pluginProject/pluginMainClass.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/themes.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcFragments_gallery.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/navDrawerActivity/srcActivity.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/AndroidModuleTemplateBuilder.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/modules/android/buildGradle.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/bottomNavActivity/srcActivity.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/noAndroidXActivity/noAndroidXActivityTemplate.kt
- templates-impl/src/main/java/com/itsaky/androidide/templates/impl/base/results.kt
- templates-api/src/main/java/com/itsaky/androidide/templates/base/base.kt
davidschachterADFA
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removal of template legacy code