Skip to content

ADFA-4061: upgrade to latest kotlin-android#1323

Merged
itsaky-adfa merged 3 commits into
stagefrom
fix/ADFA-4061
May 20, 2026
Merged

ADFA-4061: upgrade to latest kotlin-android#1323
itsaky-adfa merged 3 commits into
stagefrom
fix/ADFA-4061

Conversation

@itsaky-adfa
Copy link
Copy Markdown
Contributor

Fixes an issue with Kotlin compiler where there was a recursive reference to com.android.java.lang.ClassValue, which resulted in a StackOverflow exception. See appdevforall/kotlin-android@172a7e7 for the actual fix.

Fixes an issue with Kotlin compiler where there was a recursive reference to com.android.java.lang.ClassValue, which resulted in a StackOverflow exception

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
@itsaky-adfa itsaky-adfa requested a review from a team May 20, 2026 15:23
@itsaky-adfa itsaky-adfa self-assigned this May 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d681e48a-7845-4d53-b9f2-4d58c59116b2

📥 Commits

Reviewing files that changed from the base of the PR and between 9c0fc5a and 292c007.

📒 Files selected for processing (1)
  • subprojects/kotlin-analysis-api/build.gradle.kts

📝 Walkthrough

Release Notes

  • Upgraded kotlin-android dependency to the latest version containing a fix for a Kotlin compiler StackOverflowException caused by recursive reference to com.android.java.lang.ClassValue
    • Updated release tag from v2.3.255-414445c to v2.3.255-172a7e7
    • Updated SHA256 checksum to match the new binary artifact

Risks & Best Practices

  • ⚠️ External dependency update without visible tests: The fix is implemented in an upstream kotlin-android repository, but no test cases are included in this PR to verify the StackOverflowException is resolved
  • ⚠️ Binary artifact change: The SHA256 checksum update indicates a completely different compiled artifact is being downloaded; ensure integration testing confirms compatibility with the rest of the codebase
  • ⚠️ Limited change visibility: The actual fix exists only in the upstream kotlin-android repository (commit 172a7e7), making code review of the root cause difficult in this PR context
  • ⚠️ Frequent dependency updates: This is a recurring pattern of kotlin-android upgrades (multiple similar PRs in recent history); consider establishing a policy for batching such updates or increasing validation rigor given the transitive impact on Kotlin compilation

Walkthrough

The PR updates the Gradle build script for the Kotlin analysis API by changing the external kt-android JAR dependency metadata: the release tag used to construct the download URL and the corresponding SHA-256 checksum for integrity verification.

Changes

External kt-android dependency metadata

Layer / File(s) Summary
kt-android release tag and checksum update
subprojects/kotlin-analysis-api/build.gradle.kts
ktAndroidTag is updated to point to a new release, and the sha256Checksum is updated to match the integrity hash of the artifact at that release.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • Daniel-ADFA
  • jatezzz

Poem

🐰 A version bump in the gradle sky,
New checksums dance and tags fly high,
The kt-android jar now sings,
With hashes fresh and release wings! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: upgrading the kotlin-android dependency to the latest version, which is the primary purpose of the changeset.
Description check ✅ Passed The description is related to the changeset as it explains the motivation for the upgrade (fixing a Kotlin compiler StackOverflow issue), though it references an external fix rather than detailing the changes directly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ADFA-4061

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@itsaky-adfa itsaky-adfa merged commit ada6cd5 into stage May 20, 2026
2 checks passed
@itsaky-adfa itsaky-adfa deleted the fix/ADFA-4061 branch May 20, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants