ADFA-2553 Switch from incorrect LongPress interception to Sora LongPress handler#878
Conversation
…r to correctly select text the user intended
📝 WalkthroughWalkthroughRemoved EventBus-based long-press event plumbing and an EditorLongPressEvent type; also changed copy behavior so editors no longer include debug info by default (some code paths stop setting includeDebugInfoOnCopy). Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rated normal copy/paste (without buildInfo) from feedback copy/paste (with buildInfo)
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
To correctly select text the user intended for copy/paste from Build Output and IDE Logs
Might also fix ADFA-2536
The real bug was in copyTextToClipboard - it was prepending build info to the entire buffer then extracting with original indices, causing wrong text to be copied
Fixed by extracting selected text first, then prepending build info only when needed
Removed includeDebugInfoOnCopy = true from log views so normal copy works correctly
Share/feedback still uses getShareableContent() which includes build info