ADFA-2649 Make project actions toolbar draggable regardless of touch location

[hal-eisen-adfa]

No description provided.

[coderabbitai]

📝 Walkthrough

Release Notes - Project Actions Toolbar

Changes

• Removed touch event interception on toolbar menu buttons - Eliminated the OnTouchListener that was preventing parent views (DrawerLayout) from intercepting touch events on action buttons
• Simplified toolbar implementation - Reduced code complexity by removing unnecessary touch event handling logic while preserving click and long-click functionality

Benefits

• Toolbar is now fully draggable regardless of where users touch it
• Cleaner, more maintainable code without redundant touch event handling

⚠️ Risks & Considerations

• Potential UX conflict: Users attempting to drag the toolbar may accidentally trigger button clicks or long-clicks if they touch a menu item. Consider adding haptic feedback or visual cues to distinguish between drag and tap interactions.
• Changed interaction model: Previous implementation explicitly controlled when parent views could intercept touches. This change delegates that control entirely to the parent view, which may result in unexpected behavior if user drags originate from button areas.
• Touch responsiveness trade-off: While draggability is improved, the toolbar buttons may now be less responsive to intentional taps during drag gestures, potentially frustrating users who tap while dragging nearby.

Walkthrough

Removed a touch event listener from menu item buttons in ProjectActionsToolbar that was preventing parent view touch interception. The listener previously blocked parent views (e.g., DrawerLayout) from intercepting touch events on ACTION_DOWN. Click and long-click listeners remain functional.

Changes

Cohort / File(s)	Summary
Touch Listener Removal common/src/main/java/com/itsaky/androidide/ui/ProjectActionsToolbar.kt	Removed OnTouchListener that called requestDisallowInterceptTouchEvent() on ACTION_DOWN and re-enabled interception on ACTION_UP/ACTION_CANCEL. Parent view touch interception is now permitted on menu items.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• PR #755: Added the touch listener that intercepts parent view touch events—directly related as it introduced the code being removed in this PR.

Poem

🐰 With gentle paws, we touch and play,
No blocking hands to bar the way,
The parent views may intercept,
Touch events flow, as once was kept,
Simplicity restored today! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided, so this check cannot assess the relationship between description and changeset.	Add a pull request description explaining the change and its purpose to help reviewers understand the intent.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing touch event interception to allow the toolbar to be draggable regardless of touch location.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ADFA-2649-Make-the-project-action-toolbar-work-better

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

• ✨ 136.113.208.247/32 (new)
• 34.170.211.100/32
• 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}