ADFA-4496 feat(sync): detect phantom-process SIGKILL and show an acti…#107
Merged
Merged
Conversation
…onable message Safety net for Android 12+ phantom-process killing (the root of the share flakiness). When the OS reaps the native rsync transfer child, Process.waitFor() returns 137 (128 + SIGKILL). Detect that exit code and, instead of a generic 'exit code 137', tell the user what happened and how to prevent it (Developer options toggle on 14+, or the ADB optimization). No permissions, no logcat. - RsyncOutcome: new Transfer.KILLED + wasKilledBySignal(137); classifyTransfer maps 137 -> KILLED. Pure/JVM-tested (RsyncOutcomeTest.sigkillIsClassifiedAsKilled). - RsyncManager.startClient: handle KILLED -> onError(rsync_error_process_killed). - New string rsync_error_process_killed in en/es/fr/pt/hi/ru (translations are first-pass, worth a native review). Next slices (designed in the research doc, not in this commit): informed pre-flight using PhantomProcessHelper (detect monitor state + deep-link to Developer options), and host-side daemon-death detection.
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onable message
Safety net for Android 12+ phantom-process killing (the root of the share flakiness). When the OS reaps the native rsync transfer child, Process.waitFor() returns 137 (128 + SIGKILL). Detect that exit code and, instead of a generic 'exit code 137', tell the user what happened and how to prevent it (Developer options toggle on 14+, or the ADB optimization). No permissions, no logcat.
Next slices (designed in the research doc, not in this commit): informed pre-flight using PhantomProcessHelper (detect monitor state + deep-link to Developer options), and host-side daemon-death detection.