ADFA-4444 chore(branding): preliminary K2Go launcher icon (interim)#86
Merged
Conversation
…ot final art) Replace the KTG monogram placeholder (PR #41) with the sketch K2Go icon (brain-in-head phone, no name), so the app + README screenshots match the direction while the final icon is decided. Adaptive icon: white background + raster foreground (graphic fit to the safe zone); legacy mipmaps regenerated (square + round) at mdpi..xxxhdpi. Drops the old monogram vector foreground. Interim: a higher-quality/final icon drops in later the same way.
…d by header logo) processDebugResources failed: layout/main.xml's header ImageView references @drawable/ic_launcher_foreground, which the icon swap had removed. Re-add it as a bitmap wrapping the new @mipmap/ic_launcher_foreground, and point the adaptive icon back to @drawable/ic_launcher_foreground (single source). Header + launcher now both show the new K2Go icon.
…on the Go Bump the adaptive icon foreground fill from ~0.60 to 0.667 of the canvas height, matching Code on the Go's icon ratio (measured ~0.667), so K2Go no longer looks small with extra margin next to CotG in the launcher.
… the Go Two issues made the launcher icon look small/odd next to CotG: - the adaptive <foreground> pointed at a <bitmap gravity="center"> drawable, which is drawn at intrinsic size (not scaled to fill the foreground layer), so launchers that render the icon oversized showed it shrunk. Point the adaptive foreground at @mipmap/ic_launcher_foreground directly (scales to fill, standard adaptive output); keep the <bitmap> wrapper only for the app header ImageView. - regenerate the foreground at 0.607 of canvas height, the measured fill of CotG's vector foreground (was 0.667).
Cold start showed two different shapes: the Android 12+ system splash masks the launcher icon to a circle, but SplashActivity rendered @mipmap/ic_launcher in an ImageView as a square (adaptive icon composited, unmasked). Add a dedicated circular splash logo (white disc + foreground at 0.607, matching the masked adaptive icon) and point activity_splash.xml at it, so both startup stages show the same circle. Preliminary icon.
The Android 12+ system splash shows only the adaptive icon FOREGROUND on windowSplashScreenBackground (no white disc); the previous custom splash (white-disc logo, then earlier a white square) didn't match, so cold start showed two different shapes. Mirror Code on the Go's approach (foreground on the splash background): SplashActivity now shows @mipmap/ic_launcher_foreground at 240dp on splash_bg, so both startup stages render the same phone on the same dark background. Drop the unused splash_logo asset. Preliminary icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary / interim — not the final art. Replaces the KTG monogram placeholder (PR #41) with the sketch K2Go icon (brain-in-head phone, no name), so the app and the upcoming README screenshots match the intended direction while the final icon is still being decided.
ic_launcher(square) +ic_launcher_roundregenerated at mdpi→xxxhdpi.A higher-quality / final icon drops in later the same way. Refs ADFA-4444.