Match attach registrationToken if registration_id undefined #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey! That's magic, thanks! Are you sure that the results order corresponds to the sent order? I'm not really sure about it as ... Could you confirm before merging? |
Contributor
Author
|
Yes I'm sure and if I face anything else I'll make pull request to you 👍 |
Contributor
Author
|
Could you please update npm version as patch version 1.0.18 to make me able to update it on my main project. Thank you |
mhisham
added a commit
to mhisham/node-pushnotifications
that referenced
this pull request
Apr 17, 2017
Match attach registrationToken if registration_id undefined (appfeel#45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced a problem when sending GCM Message and want to update my database to remove invalid Tokens.
I receive a response like this:
{ messageId: undefined,
regId: undefined,
error: Error: NotRegistered ..
}
so i replaced undefined token with regToken by order of tokens