Made the apn's production setting more visible #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me hours to figure out why I was getting BadDeviceToken in production while on my test iPhone everything was working great. I had to go to the node-apn package to figure this out. The production setting should be shown in the settings (as it is inside the node-apn readme) so people can see they have to toggle it.
Collaborator
|
Hello @Avery246813579, I like the proposed change to add the Could you change the explanation to simply explain that |
alex-friedl
reviewed
Apr 6, 2018
| keyId: 'ABCD', | ||
| teamId: 'EFGH', | ||
| }, | ||
| production: false, |
Collaborator
There was a problem hiding this comment.
maybe add an explaining comment here and remove the comment down below?
Collaborator
|
Closed in favor of ad1c566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me hours to figure out why I was getting BadDeviceToken in production while on my test iPhone everything was working great. I had to go to the node-apn package to figure out I needed production to be true inside the apn settings. The weird thing is, this was never said ANYWHERE inside the readme.
The production setting should be displayed on the readme (like the node-apn readme) so people can see they have to toggle it.