Enhance visit to support multiple paths [fix #90]#103
Merged
dtognazzini merged 8 commits intomasterfrom May 13, 2015
Merged
Conversation
ipmsteven
force-pushed
the
enhanceVisit
branch
2 times, most recently
from
4647fed to
200dffc
Compare
ipmsteven
changed the title
Contributor
There was a problem hiding this comment.
RE delete: We should avoid modifying input parameters.
Contributor
|
Please update the README to document this functionality. |
Contributor
There was a problem hiding this comment.
The :via option shouldn't be forwarded to generate_path.
ipmsteven
force-pushed
the
enhanceVisit
branch
3 times, most recently
from
20cf1e4 to
5b2bb7e
Compare
Contributor
There was a problem hiding this comment.
generate_path should receive the path and the exact same args as passed to visit except for the :via key when present.
Please add tests covering the following invocations:
PageObjects::Books::ShowPage.visit(book, :format => :json)
# should invoke generate_path(<path>, book, :format => :json)
PageObjects::Books::ShowPage.visit(book, :format => :json, :via => :something)
# should invoke generate_path(<path>, book, :format => :json)
PageObjects::Books::ShowPage.visit(something, something_else)
# should invoke generate_path(<path>, something, something_else)
PageObjects::Books::ShowPage.visit(something, something_else, :via => "something")
# should invoke generate_path(<path>, something, something_else)
ipmsteven
force-pushed
the
enhanceVisit
branch
3 times, most recently
from
052a7a2 to
4a36744
Compare
Contributor
|
Changes look good! Merge on green. |
Contributor
|
Great! |
dtognazzini
added a commit
that referenced
this pull request
May 13, 2015
Enhance visit to support multiple paths [fix #90]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.