Fix build error for aepos test under rails 3.1&&ruby1.8.7#104
Merged
dtognazzini merged 1 commit intomasterfrom Dec 24, 2014
Merged
Fix build error for aepos test under rails 3.1&&ruby1.8.7#104dtognazzini merged 1 commit intomasterfrom
dtognazzini merged 1 commit intomasterfrom
Conversation
Detail: The current version(released on December 19, 2014) of i18n(which rails depends on) REQUIRED RUBY VERSION: >= 1.9.3 (https://rubygems.org/gems/i18n) However the Rails-3.1.12 that used in aepos integration test depends on i18n '~> 0.6' (https://github.com/rails/rails/blob/3-1-stable/actionpack/actionpack.gemspec) (https://github.com/rails/rails/blob/3-1-stable/activemodel/activemodel.gemspec) As new version of i18n released, the version of i18n for rails 3.1.12 resolved to 0.7.0 but that version requires ruby version >= 1.9.3 which make bundle install errors: (https://travis-ci.org/appfolio/ae_page_objects/jobs/43120957) Fix: add i18n pessimistic version constraint (~> 0.6.0) under rails 3.1.12 && ruby 1.8.7
ipmsteven
force-pushed
the
fixReeBuildForRails31
branch
from
7b78bed to
47e054c
Compare
Contributor
|
Thanks for fixing this! |
dtognazzini
added a commit
that referenced
this pull request
Dec 24, 2014
Fix build error for aepos test under rails 3.1&&ruby1.8.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail:
The current version(released on December 19, 2014) of i18n(which rails depends on) REQUIRED RUBY VERSION: >= 1.9.3 (https://rubygems.org/gems/i18n)
However the Rails-3.1.12 that used in aepos integration test depends on i18n '~> 0.6'
(https://github.com/rails/rails/blob/3-1-stable/actionpack/actionpack.gemspec)
(https://github.com/rails/rails/blob/3-1-stable/activemodel/activemodel.gemspec)
As new version of i18n released, the version of i18n in rails 3.1.12 resolved to
0.7.0but that version requiresruby version >= 1.9.3 which make bundle install errors under 1.8.7
(https://travis-ci.org/appfolio/ae_page_objects/jobs/43120957)
Fix:
add i18n pessimistic version constraint (~> 0.6.0) under rails 3.1.12 && ruby 1.8.7