Fix method_missing for "class" in ElementProxy#128
Merged
dtognazzini merged 1 commit intoappfolio:masterfrom Jun 9, 2015
Merged
Fix method_missing for "class" in ElementProxy#128dtognazzini merged 1 commit intoappfolio:masterfrom
dtognazzini merged 1 commit intoappfolio:masterfrom
Conversation
jacob-carlborg
force-pushed
the
class_element_proxy
branch
from
42e0980 to
d6f97cc
Compare
A fake expectation on 'implicit_element', that it should never be called, is made in the test. It seems it's not possible to use 'expects' on ElementProxy which has removed all (most) methods and implements 'method_missing'.
Contributor
Author
|
Updated with a test added. |
Contributor
|
Looks good. Thanks! |
dtognazzini
added a commit
that referenced
this pull request
Jun 9, 2015
Fix method_missing for "class" in ElementProxy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fake expectation on 'implicit_element', that it should never be called, is made in the test. It seems it's not possible to use 'expects' on ElementProxy which has removed all (most) methods and implements 'method_missing'.