Skip to content

Avoid using deprecated code in tests #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtognazzini merged 1 commit into from
Apr 27, 2016
Merged

Avoid using deprecated code in tests #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions test/test_apps/shared/test/selenium/page_object_integration_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,36 +183,36 @@ def test_element_proxy
Capybara.using_wait_time(1) do
assert author.rating.star.present?
assert author.rating.star.visible?
assert_false author.rating.star.not_present?
assert_false author.rating.star.not_visible?
assert_false author.rating.star.absent?
assert_false author.rating.star.hidden?
end

assert_nothing_raised do
author.rating.star.wait_for_presence(0)
author.rating.star.wait_until_present(0)
end

assert_raises AePageObjects::ElementNotAbsent do
author.rating.star.wait_for_absence(1)
author.rating.star.wait_until_absent(1)
end

Capybara.using_wait_time(1) do
author.rating.hide_star
assert author.rating.star.present?
assert_false author.rating.star.visible?
assert_false author.rating.star.not_present?
assert author.rating.star.not_visible?
assert_false author.rating.star.absent?
assert author.rating.star.hidden?

author.rating.show_star
assert author.rating.star.present?
assert author.rating.star.visible?
assert_false author.rating.star.not_present?
assert_false author.rating.star.not_visible?
assert_false author.rating.star.absent?
assert_false author.rating.star.hidden?

author.rating.remove_star
assert_false author.rating.star.present?
assert_false author.rating.star.visible?
assert author.rating.star.not_present?
assert author.rating.star.not_visible?
assert author.rating.star.absent?
assert author.rating.star.hidden?
end
end

Expand All @@ -227,23 +227,23 @@ def test_element_proxy__present_then_absent
author.rating.remove_star

# use new object
assert author.rating.star.not_present?
assert author.rating.star.absent?

# use existing object
assert star.not_present?
assert star.absent?
end

def test_element_proxy__not_present
author = PageObjects::Authors::NewPage.visit
assert_false author.missing.present?
assert author.missing.not_present?
assert author.missing.absent?

assert_nothing_raised do
author.missing.wait_for_absence(0)
author.missing.wait_until_absent(0)
end

assert_raises AePageObjects::ElementNotPresent do
author.missing.wait_for_presence(2)
author.missing.wait_until_present(2)
end
end

Expand Down