Backport simplified testing from master.#168
Merged
dtognazzini merged 4 commits into1-stablefrom May 13, 2016
Merged
Conversation
added 4 commits
May 12, 2016 17:18
This commit changes the testing combinations to the following: Unit tests - run against various versions of Capybara and Ruby Integration tests - run against various versions of Capybara and Rails using the most recent version of Ruby supported by the version of Rails used. The many versions of Rails are used to verify the ApplicationRouter logic. This could be simplified by extracting an ae_page_objects-rails gem (#83), reducing the integration test suite to use a single Rails version. (cherry picked from commit f4b9fe9)
(cherry picked from commit f129fe3)
(cherry picked from commit cb06647)
With these changes: Unit tests run against every version of Capybara _at most once_ and against both the minimum and maximum Ruby version _at least once_. Integration tests run against every version of Rails at least once and every version of Capybara at least once. The version of Ruby used in integration tests depends on the version of Rails used. In the current state, this means that the most recent Rails application (4.2) has all of the Capybara version permutations since the Ruby version supported by the Rails application (2.2.5) is supported by all the Capybara versions. (cherry picked from commit d7dbfa8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #167