Skip to content

Use {exact: true} only for XPath selectors#190

Merged
rmacklin merged 1 commit intomasterfrom
only-use-exact-for-xpath
Sep 19, 2016
Merged

Use {exact: true} only for XPath selectors#190
rmacklin merged 1 commit intomasterfrom
only-use-exact-for-xpath

Conversation

@tlconnor
Copy link
Copy Markdown

The use of {exact: true} is currently unclear within AePageObjects::Collection#item_xpath

This PR makes the following changes:

  • limits the use of {exact: true} to XPath selectors only (it has no effect otherwise)
  • add comments explaining the use of {exact: true}
  • add unit tests for XPath selectors and the use of {exact: true}

@tlconnor tlconnor force-pushed the only-use-exact-for-xpath branch from bb2de54 to 84443f5 Compare September 19, 2016 20:35
@rmacklin
Copy link
Copy Markdown
Contributor

Thanks

@rmacklin rmacklin merged commit 488e50e into master Sep 19, 2016
@rmacklin rmacklin deleted the only-use-exact-for-xpath branch September 19, 2016 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants