Slight performance improvement for AePageObjects::Collection#each#191
Merged
Slight performance improvement for AePageObjects::Collection#each#191
Conversation
tlconnor
force-pushed
the
collectionEachPerformanceImprovement
branch
from
1033529 to
2443432
Compare
bboe
reviewed
Sep 19, 2016
| @@ -36,7 +36,7 @@ def [](index) | |||
|
|
|||
| def each | |||
| (0..(size - 1)).each do |index| | |||
Contributor
There was a problem hiding this comment.
Not completely related, but can this be size.times?
tlconnor
force-pushed
the
collectionEachPerformanceImprovement
branch
from
2443432 to
044ce67
Compare
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
AePageObjects::Collection#eachuses#at(index)for each loop iteration. This means that the query to determine the collection size will be executed for each iteration of the loop.This PR changes
AePageObjects::Collection#eachto instead use#item_at(index)which skips the unnecessary size check and reduces the total number of queries performed.