Conversation
| window.location.href = event.target.getAttribute("data-href"); | ||
| }, 3000); | ||
| }) | ||
| }) No newline at end of file |
| end | ||
| end | ||
|
|
||
| class Rails5 < Rails4; end |
There was a problem hiding this comment.
Perhaps instead of subclassing, we could rename this class to reflect that it is for Rails 4+?
There was a problem hiding this comment.
@jonkessler
I was thinking about that but failed to make a good name :(
any suggestion for naming?
|
|
||
| def test_window_change_to__multiple_pages | ||
| book = Book.create!(:title => "Brave New World") | ||
| book = Book.create!(:title => 'Brave New World', :author => Author.create!(:last_name => 'Huxley')) |
There was a problem hiding this comment.
Could use new hash syntax in these two spots, since we're changing this.
Have to require rake/testtask.rb explicitly because of rails/rails#19997
xpath 2.1.0 change the return value of exact match string here teamcapybara/xpath@f2ea41a#diff-d44bd2b38096d0fafd605a26ff4bfc9dR74
ipmsteven
force-pushed
the
hexAddRails5Support
branch
from
c596fb1 to
82f9c9a
Compare
magneland
left a comment
magneland
left a comment
There was a problem hiding this comment.
Looks good overall.
Can you also update this sentence in README.md:
AePageObjects is built to work with Rails (versions 3.X-4.X) out of the box.
Can you also update this sentence in the development.md:
`AePageObjects::ApplicationRouter` is tested against various versions of Rails in the _test/test_apps_ directory (currently 3.0 to 4.2).
| case(RUBY_VERSION) | ||
| when "2.2.5" then | ||
|
|
||
| appraise "capybara-2.2-ruby#{RUBY_VERSION}" do |
There was a problem hiding this comment.
So many capybaras...are they all necessary?
On the other hand, there are newer versions as well.
There was a problem hiding this comment.
So many capybaras...are they all necessary?
I think we did it on purpose base on this https://github.com/appfolio/ae_page_objects/blob/master/development.md#integration
On the other hand, there are newer versions as well.
yea, maybe we should have separate PR for adding new capybara support
ipmsteven
force-pushed
the
hexAddRails5Support
branch
from
4c7078a to
39f777b
Compare
3 participants
No description provided.