Merged
Conversation
ipmsteven
reviewed
Aug 30, 2017
| path :new_user_session | ||
|
|
||
| def login!(username, password) | ||
| def login_as!(username, password) |
Contributor
There was a problem hiding this comment.
Thanks for the PR!
could you change all the usages or definitions for login! method in this doc?
joelbandi
force-pushed
the
fixSmallDocumentationTypo
branch
from
18cbeba to
d37829e
Compare
ipmsteven
approved these changes
Aug 30, 2017
Contributor
|
Thanks for being proactive! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conventions section in the README file has a
LoginPageimplementation with a method namedlogin!but it's used everywhere asLoginPage.login_as!.Renamed all instances of
login_as!tologin!