Prevent AePageObjects::Collection#size from waiting#207
Merged
Conversation
tlconnor
changed the title
tlconnor
force-pushed
the
fixCollectionSizeWait
branch
from
e1f728b to
96eb3b6
Compare
spjsschl
approved these changes
Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue has been found where
AePageObjects::Collection#sizewaits for up toCapybara.default_wait_time. If#sizeis used within anAePageObjects#wait_untilblock it is possible for the block to fail after only 1 iteration.The solution is to prevent Capybara from waiting within
#sizecalls.