Rails 6 support / Bump tested ruby versions / Clean up#209
Merged
wpliao1989 merged 13 commits intomasterfrom Apr 30, 2020
Merged
Rails 6 support / Bump tested ruby versions / Clean up#209wpliao1989 merged 13 commits intomasterfrom
wpliao1989 merged 13 commits intomasterfrom
Conversation
added 4 commits
April 29, 2020 16:34
Change to 2.5.8, 2.6.6 and 2.7.1 to match latest stable ruby versions.
selenium_helper was symlinked which caused a lot of issues.
wpliao1989
force-pushed
the
wlTestAgainstRails6
branch
2 times, most recently
from
368ed48 to
8ba4023
Compare
added 2 commits
April 29, 2020 17:31
wpliao1989
force-pushed
the
wlTestAgainstRails6
branch
3 times, most recently
from
50aa888 to
0c99903
Compare
Closed
wpliao1989
force-pushed
the
wlTestAgainstRails6
branch
from
0c99903 to
34dfbb9
Compare
added 6 commits
April 30, 2020 11:32
wpliao1989
force-pushed
the
wlTestAgainstRails6
branch
from
34dfbb9 to
bf56fe1
Compare
wpliao1989
changed the title
pkmiec
approved these changes
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Rails 6
Move Rails 5.0 to Rails 5.2
Remove Rails 4.2
Bump Ruby versions
Fix
AePageObjects is not tested against Rails xxx and may behave in an undefined manner.warningNotes
There are a few deprecation warnings on Ruby 2.7 about keyword arguments. We should address them later.