Wrapped Capybara::ElementNotFound error in AePageObjects::LoadingElementFailed#67
Merged
dtognazzini merged 1 commit intomasterfrom Sep 10, 2014
Merged
Wrapped Capybara::ElementNotFound error in AePageObjects::LoadingElementFailed#67dtognazzini merged 1 commit intomasterfrom
dtognazzini merged 1 commit intomasterfrom
Conversation
ipmsteven
force-pushed
the
wrapElementNotFound
branch
2 times, most recently
from
c99b2ac to
2bdc8b3
Compare
…entFailed so that ElementProxy#presence can handle the case where locating the element succeeds but the load ensuring checks fail.
dtognazzini
force-pushed
the
wrapElementNotFound
branch
from
2bdc8b3 to
e40274e
Compare
dtognazzini
added a commit
that referenced
this pull request
Sep 10, 2014
Wrapped Capybara::ElementNotFound error in AePageObjects::LoadingElementFailed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capybara::ElementNotFound is raised from Capybara#find calls.
Prior to these changes creating a new Element could fail for either Capybara::ElementNotFound or AePageObjects::LoadingFailed.
The changes map Capybara::ElementNotFound exceptions to AePageObjects::LoadingFailed and fix a bug in ElementProxy#presence which was only handling Capybara::ElementNotFound.
Additionally, these changes make the loading failure mode across Documents and Elements consistent by having both modes raise AePageObjects::LoadingFailed subtypes for all loading failures.