Skip to content

make PageObject node throw AePageObjects::LoadingElementFailed instead of Capybara::ElementNotFound#72

Merged
dtognazzini merged 2 commits intomasterfrom
aePageObjectsNodeException
Sep 30, 2014
Merged

make PageObject node throw AePageObjects::LoadingElementFailed instead of Capybara::ElementNotFound#72
dtognazzini merged 2 commits intomasterfrom
aePageObjectsNodeException

Conversation

@ipmsteven
Copy link
Copy Markdown
Contributor

No description provided.

@dtognazzini
Copy link
Copy Markdown
Contributor

Please add tests for this change.

@ipmsteven ipmsteven force-pushed the aePageObjectsNodeException branch 3 times, most recently from d4fb471 to f9ed95f Compare September 29, 2014 20:37
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this file to match the module name.

@ipmsteven ipmsteven force-pushed the aePageObjectsNodeException branch from f9ed95f to 884d30a Compare September 29, 2014 23:48
@ipmsteven ipmsteven force-pushed the aePageObjectsNodeException branch from 686f5f5 to 17db7eb Compare September 30, 2014 16:48
dtognazzini added a commit that referenced this pull request Sep 30, 2014
make PageObject node throw AePageObjects::LoadingElementFailed instead of Capybara::ElementNotFound
@dtognazzini dtognazzini merged commit d7a81db into master Sep 30, 2014
@dtognazzini dtognazzini deleted the aePageObjectsNodeException branch September 30, 2014 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants