fix Routing incorrectly matches documents issue and fix for #63#73
Merged
dtognazzini merged 1 commit intomasterfrom Oct 4, 2014
Merged
fix Routing incorrectly matches documents issue and fix for #63#73dtognazzini merged 1 commit intomasterfrom
dtognazzini merged 1 commit intomasterfrom
Conversation
ipmsteven
force-pushed
the
fixRoutingMatch
branch
6 times, most recently
from
7e85eea to
7cba4ea
Compare
Contributor
|
This fix is dependent on the order of the parameters to Here's a failing test that highlights the parameter order issue. This test needs to pass. Another test should be written to the order in which routes are yielded. |
ipmsteven
force-pushed
the
fixRoutingMatch
branch
from
7cba4ea to
01d1b3a
Compare
Contributor
|
After some more reading and experimentation, I see how these changes address the issue. As we discussed via chat, please add comments documenting the "why" of your changes and add a test case covering all the permutations. Thanks! |
ipmsteven
force-pushed
the
fixRoutingMatch
branch
2 times, most recently
from
6870b70 to
32b37c1
Compare
ipmsteven
changed the title
ipmsteven
force-pushed
the
fixRoutingMatch
branch
from
32b37c1 to
ecb6303
Compare
Contributor
There was a problem hiding this comment.
This comment also applies to Rails23#recognizes?
Contributor
Author
There was a problem hiding this comment.
yes, but there is no inner loop here. I added comment.
ipmsteven
force-pushed
the
fixRoutingMatch
branch
from
ecb6303 to
36dc87c
Compare
ipmsteven
force-pushed
the
fixRoutingMatch
branch
from
36dc87c to
501f7f2
Compare
dtognazzini
added a commit
that referenced
this pull request
Oct 4, 2014
fix Routing incorrectly matches documents issue and fix for #63
Contributor
|
Addresses issue #63 |
BadassBison
added a commit
that referenced
this pull request
Apr 12, 2026
…VE-2025-30360 Fixes Dependabot alerts #68–#73 across test app directories. Severities: MEDIUM CVEs: CVE-2025-30359, CVE-2025-30360 Package: webpack-dev-server (devDependency in test/test_apps/*/package.json)
2 tasks
BadassBison
added a commit
that referenced
this pull request
Apr 12, 2026
…VE-2025-30360 Fixes Dependabot alerts #68–#73 across test app directories. Severities: MEDIUM CVEs: CVE-2025-30359, CVE-2025-30360 Package: webpack-dev-server (devDependency in test/test_apps/*/package.json)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.