ElementProxy enhancements and fix for #65#78
Conversation
There was a problem hiding this comment.
maybe use is_absent to keep the naming consistent?
|
do we need |
|
No. Good catch. I'll remove. |
da111f0 to
2f4284f
Compare
ElementProxy enhancements and fix for #65
There was a problem hiding this comment.
If the load_element is succeed, the check_absece method will return false. However in the Waiter.wait_for the check_absence will called again and again until the time expired. I think we should return false and skip the wait_for if the load_element is succeed.
There was a problem hiding this comment.
I don't understand. check_absence should only return true if loading the element failed, which indicates the element is absent. If loading the element succeeds, then the element is still present. We want to wait for the element to be absent.
New methods:
wait_for_absence(timeout = nil)
wait_for_presence(timeout = nil)
Fix for #65