fix: change screen id as long for Xcode 13.3#573
Merged
Conversation
KazuCocoa
changed the title
mykola-mokhnach
changed the title
mykola-mokhnach
approved these changes
Mar 19, 2022
KazuCocoa
commented
Mar 19, 2022
| { | ||
| _Bool _isMainScreen; | ||
| int _displayID; | ||
| long long _displayID; |
Member
Author
There was a problem hiding this comment.
This change occurred since Xcode 10.2, so this change must be safe
KazuCocoa
commented
Mar 19, 2022
| - (double)scale; | ||
| - (id)initWithDisplayID:(int)arg1 isMainScreen:(_Bool)arg2; | ||
|
|
||
| - (id)initWithDisplayID:(long long)arg1 isMainScreen:(_Bool)arg2 device:(id)arg3 screenDataSource:(id)arg4; |
Member
Author
There was a problem hiding this comment.
this change is also since xcode 10.2
Member
Author
|
I've updated relevant types. |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
## [4.1.6](v4.1.5...v4.1.6) (2022-03-20) ### Bug Fixes * change screen id as long for Xcode 13.3 ([#573](#573)) ([004c766](004c766))
|
🎉 This PR is included in version 4.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
KazuCocoa
added a commit
that referenced
this pull request
Mar 20, 2022
* feat: update screen id as long since Xcode 13.3 * update long long * convert unsigned int to long long in displayId stuff
10 tasks
manabuaota
added a commit
to manabuaota/airtest-netease
that referenced
this pull request
Feb 14, 2026
## [4.1.6](appium/WebDriverAgent@v4.1.5...v4.1.6) (2022-03-20) ### Bug Fixes * change screen id as long for Xcode 13.3 ([#573](appium/WebDriverAgent#573)) ([004c766](appium/WebDriverAgent@004c766))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For appium/appium#16604.
not fully checked, but it seems they changed
screenIDaslong longinstead ofunsigned int.I haven't fully checked with the relevant code yet. Probably we need to update
screenIDrelated code as well.With Xcode 13.0 x iOS 13.4 also had no issue as
long. I'll test more variations, then probably we can only use "long" since it is bigger thanint.I cleaned my local xcodebuild cache every time, but potentially cache remained as my mistake