refactor: Drop workarounds for legacy iOS versions#696
refactor: Drop workarounds for legacy iOS versions#696mykola-mokhnach merged 2 commits intomasterfrom
Conversation
|
Can we bump the major version as well to make the drop kind of explicit by adding Removing itself is 👍 |
The change is not breaking because we officially stated way before that xcode 13 is the minimum supported version. @jlipps what do you think? |
|
Yeah this is a good question. Saying what we support and what we don't doesn't necessarily mean we shouldn't follow semver when enacting our support policies. Saying "we don't support iOS X anymore" is fine, but perhaps we should still release a new major version of the code so that users aren't surprised. If they complain, we point to the policy. In this case I think we should probably release as a breaking change. |
Then I would probably have multiple breaking changes. It would make sense to combine them and only bump the major version once |
yeah makes sense |
## [5.0.0](v4.15.1...v5.0.0) (2023-05-14) ### ⚠ BREAKING CHANGES * The minimum supported xCode/iOS version is now 13/15.0 ### Code Refactoring * Drop workarounds for legacy iOS versions ([#696](#696)) ([bb562b9](bb562b9))
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [5.0.0](appium/WebDriverAgent@v4.15.1...v5.0.0) (2023-05-14) ### ⚠ BREAKING CHANGES * The minimum supported xCode/iOS version is now 13/15.0 ### Code Refactoring * Drop workarounds for legacy iOS versions ([#696](appium/WebDriverAgent#696)) ([bb562b9](appium/WebDriverAgent@bb562b9))
The minimum supported iOS version is now 15, so we do not really care about the older stuff now