Skip to content

chore: remove unused FBBaseActionsParser and cleanup imports in FBConfiguration#943

Merged
mykola-mokhnach merged 2 commits intoappium:masterfrom
aluedeke:library_cleanup
Oct 7, 2024
Merged

chore: remove unused FBBaseActionsParser and cleanup imports in FBConfiguration#943
mykola-mokhnach merged 2 commits intoappium:masterfrom
aluedeke:library_cleanup

Conversation

@aluedeke
Copy link
Copy Markdown

@aluedeke aluedeke commented Oct 7, 2024

to be able to use WDA lib as a lib this cleanup helps

  • FBBaseActionsParser isn't used in the xcode project
  • imports in FBConfiguration should be part of the impl not the header, so an reexport isn't needed

@aluedeke aluedeke changed the title remove unused FBBaseActionsParser and cleanup imports in FBConfiguration style: remove unused FBBaseActionsParser and cleanup imports in FBConfiguration Oct 7, 2024
@mykola-mokhnach
Copy link
Copy Markdown

Please change the PR type to chore: to trigger automatic version bump

@aluedeke aluedeke changed the title style: remove unused FBBaseActionsParser and cleanup imports in FBConfiguration chore: remove unused FBBaseActionsParser and cleanup imports in FBConfiguration Oct 7, 2024
@mykola-mokhnach mykola-mokhnach merged commit a2173d0 into appium:master Oct 7, 2024
github-actions Bot pushed a commit that referenced this pull request Oct 7, 2024
## [8.9.3](v8.9.2...v8.9.3) (2024-10-07)

### Miscellaneous Chores

* remove unused FBBaseActionsParser and cleanup imports in FBConfiguration ([#943](#943)) ([a2173d0](a2173d0))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 7, 2024

🎉 This PR is included in version 8.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KazuCocoa KazuCocoa added the size:S contribution size: S label Nov 2, 2024
@jlipps
Copy link
Copy Markdown
Member

jlipps commented Nov 7, 2024

Hi @aluedeke, congrats, the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you!

@aluedeke
Copy link
Copy Markdown
Author

aluedeke commented Nov 7, 2024

@jlipps thx for the offer but no need to compensate me for my contributions.

manabuaota added a commit to manabuaota/airtest-netease that referenced this pull request Feb 14, 2026
## [8.9.3](appium/WebDriverAgent@v8.9.2...v8.9.3) (2024-10-07)

### Miscellaneous Chores

* remove unused FBBaseActionsParser and cleanup imports in FBConfiguration ([#943](appium/WebDriverAgent#943)) ([a2173d0](appium/WebDriverAgent@a2173d0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released size:S contribution size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants